Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: allow sending notifications to authenticated EdgeX endpoints #4763

Merged

Conversation

jrtitus
Copy link
Contributor

@jrtitus jrtitus commented Feb 23, 2024

Closes #4747

If your build fails due to your commit message not passing the build checks, please review the guidelines here: https://github.com/edgexfoundry/edgex-go/blob/main/.github/Contributing.md

PR Checklist

Please check if your PR fulfills the following requirements:

  • I am not introducing a breaking change (if you are, flag in conventional commit message with BREAKING CHANGE: describing the break)
  • I am not introducing a new dependency (add notes below if you are)
  • I have added unit tests for the new feature or bug fix (if not, why?)
  • I have fully tested (add details below) this the new feature or bug fix (if not, why?)
  • I have opened a PR for the related docs change (if not, why?)

Testing Instructions

See #4747 (comment)

New Dependency Instructions (If applicable)

In draft state due to dependency on change in go-mod-core-contracts

@codecov-commenter
Copy link

codecov-commenter commented Feb 23, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 41.55%. Comparing base (29dca6d) to head (2cd8e92).

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #4763   +/-   ##
=======================================
  Coverage   41.55%   41.55%           
=======================================
  Files         105      105           
  Lines        9834     9834           
=======================================
  Hits         4087     4087           
  Misses       5395     5395           
  Partials      352      352           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

lenny-goodell
lenny-goodell previously approved these changes Feb 27, 2024
Copy link
Member

@lenny-goodell lenny-goodell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jrtitus jrtitus marked this pull request as ready for review February 28, 2024 02:07
lenny-goodell
lenny-goodell previously approved these changes Feb 28, 2024
Copy link

sonarcloud bot commented Mar 2, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

Copy link
Member

@cloudxxx8 cloudxxx8 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@cloudxxx8 cloudxxx8 merged commit a48d639 into edgexfoundry:main Mar 4, 2024
6 checks passed
@jrtitus jrtitus deleted the feat/authenticated-notifications branch March 4, 2024 18:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support notifications should be able to communicate with authenticated EdgeX endpoints
4 participants