Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add LastConnected metric to device service common config #4685

Merged
merged 1 commit into from
Sep 21, 2023

Conversation

lindseysimple
Copy link
Contributor

@lindseysimple lindseysimple commented Sep 20, 2023

fixes #4684. Add LastConnected metric to device service common config.

If your build fails due to your commit message not passing the build checks, please review the guidelines here: https://github.com/edgexfoundry/edgex-go/blob/main/.github/Contributing.md

PR Checklist

Please check if your PR fulfills the following requirements:

  • I am not introducing a breaking change (if you are, flag in conventional commit message with BREAKING CHANGE: describing the break)
  • I am not introducing a new dependency (add notes below if you are)
  • I have added unit tests for the new feature or bug fix (if not, why?)
  • I have fully tested (add details below) this the new feature or bug fix (if not, why?)
  • I have opened a PR for the related docs change (if not, why?) - feat: Add LastConnected metric to common config edgex-docs#1231

Testing Instructions

New Dependency Instructions (If applicable)

fixes edgexfoundry#4684. Add LastConnected metric to device service common config.

Signed-off-by: Lindsey Cheng <[email protected]>
@sonarcloud
Copy link

sonarcloud bot commented Sep 20, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@codecov-commenter
Copy link

Codecov Report

Merging #4685 (596b81e) into main (b006ed3) will not change coverage.
The diff coverage is n/a.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

@@           Coverage Diff           @@
##             main    #4685   +/-   ##
=======================================
  Coverage   41.55%   41.55%           
=======================================
  Files         105      105           
  Lines        9835     9835           
=======================================
  Hits         4087     4087           
  Misses       5396     5396           
  Partials      352      352           

Copy link
Member

@lenny-goodell lenny-goodell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@cloudxxx8 cloudxxx8 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@cloudxxx8 cloudxxx8 merged commit 4f9cf71 into edgexfoundry:main Sep 21, 2023
9 checks passed
@lindseysimple lindseysimple deleted the issue-4684 branch August 2, 2024 04:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add LastConnected metric to device services common config
4 participants