Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: Remove the unsupported object and field from Scheduler API doc #3634

Merged
merged 2 commits into from
Jul 29, 2021
Merged

docs: Remove the unsupported object and field from Scheduler API doc #3634

merged 2 commits into from
Jul 29, 2021

Conversation

weichou1229
Copy link
Member

Close: #3629

PR Checklist

Please check if your PR fulfills the following requirements:

  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)

If your build fails due to your commit message not passing the build checks, please review the guidelines here: https://github.com/edgexfoundry/edgex-go/blob/master/.github/Contributing.md.

What is the current behavior?

Issue Number: #3629

What is the new behavior?

The requestBody in the RESTAddress should be removed, because we have moved it to the content field in IntervalAction.
MQTTAddress is unsupported, so it should be removed.

Does this PR introduce a breaking change?

  • Yes
  • No

New Imports

  • Yes
  • No

Specific Instructions

Are there any specific instructions or things that should be known prior to reviewing?

Other information

weichou1229 and others added 2 commits July 27, 2021 10:57
The requestBody in the RESTAddress should be removed, because we have moved it to the content field in IntervalAction.
MQTTAddress is unsupported, so it should be removed.

Close: #3629
Signed-off-by: weichou <[email protected]>
@sonarcloud
Copy link

sonarcloud bot commented Jul 29, 2021

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
8.1% 8.1% Duplication

@codecov-commenter
Copy link

Codecov Report

Merging #3634 (894ca44) into main (7434bca) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #3634   +/-   ##
=======================================
  Coverage   47.29%   47.29%           
=======================================
  Files         112      112           
  Lines        9174     9174           
=======================================
  Hits         4339     4339           
  Misses       4462     4462           
  Partials      373      373           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7434bca...894ca44. Read the comment docs.

Copy link
Member

@cloudxxx8 cloudxxx8 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@cloudxxx8 cloudxxx8 merged commit 7f897f3 into edgexfoundry:main Jul 29, 2021
@weichou1229 weichou1229 deleted the issue-3629 branch July 29, 2021 23:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove the unsupported object and field from Scheduler API document
3 participants