Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: Update to use go-mod-messaging v2 #3032

Merged
merged 3 commits into from
Jan 15, 2021

Conversation

lenny-goodell
Copy link
Member

@lenny-goodell lenny-goodell commented Jan 14, 2021

PR Checklist

Please check if your PR fulfills the following requirements:

  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)

If your build fails due to your commit message not passing the build checks, please review the guidelines here: https://github.com/edgexfoundry/edgex-go/blob/master/.github/Contributing.md.

What is the current behavior?

Currently using go-mod-messaging V0.x.x

Issue Number: #3031

What is the new behavior?

Now using go-mod-messaging V2.x.x

Does this PR introduce a breaking change?

  • Yes
  • No

New Imports

  • Yes
  • No

Specific Instructions

Are there any specific instructions or things that should be known prior to reviewing?

Other information

jpwhitemn
jpwhitemn previously approved these changes Jan 14, 2021
Copy link
Member

@jpwhitemn jpwhitemn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

ernestojeda
ernestojeda previously approved these changes Jan 14, 2021
Copy link
Contributor

@ernestojeda ernestojeda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lenny-goodell lenny-goodell linked an issue Jan 14, 2021 that may be closed by this pull request
@codecov-io
Copy link

codecov-io commented Jan 15, 2021

Codecov Report

Merging #3032 (cf465e0) into master (fd35963) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #3032   +/-   ##
=======================================
  Coverage   40.28%   40.28%           
=======================================
  Files         158      158           
  Lines       13736    13736           
=======================================
  Hits         5533     5533           
  Misses       7882     7882           
  Partials      321      321           
Impacted Files Coverage Δ
internal/core/data/event.go 60.83% <ø> (ø)
internal/core/data/init.go 0.00% <ø> (ø)
internal/core/data/router.go 3.48% <ø> (ø)
internal/core/data/v2/application/event.go 56.75% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fd35963...cf465e0. Read the comment docs.

@sonarcloud
Copy link

sonarcloud bot commented Jan 15, 2021

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

Copy link
Contributor

@ernestojeda ernestojeda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lenny-goodell lenny-goodell merged commit c2d5dc1 into edgexfoundry:master Jan 15, 2021
@lenny-goodell lenny-goodell deleted the v2-messaging branch January 15, 2021 16:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update to use new go-mod-messaging V2
4 participants