Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cloud version support #36

Merged
merged 31 commits into from
Jan 29, 2022
Merged

Cloud version support #36

merged 31 commits into from
Jan 29, 2022

Conversation

paulotruta
Copy link
Member

Adding some useful flags and cases for cloud version support

@paulotruta paulotruta requested a review from inverse June 15, 2021 11:39
@paulotruta paulotruta self-assigned this Jun 15, 2021
@paulotruta paulotruta added the enhancement New feature or request label Jun 15, 2021
@@ -27,4 +27,15 @@ public function getUptimeInSeconds(): int

return $uptime;
}

public function getReleaseVersion(): ?string
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should this have a default value? Perhaps we could have an Enum type class to represent the type?

@paulotruta paulotruta changed the title Cloud version support [WIP] Cloud version support Jun 16, 2021
src/src/Controller/RegistrationController.php Show resolved Hide resolved
src/src/Controller/RegistrationController.php Show resolved Hide resolved
src/src/Controller/RegistrationController.php Show resolved Hide resolved
src/src/Controller/SecurityController.php Show resolved Hide resolved
src/src/Factory/TaskFactory.php Outdated Show resolved Hide resolved

public const LOGIN_ROUTE = 'app_login';

private $entityManager;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could type these

@paulotruta paulotruta changed the title [WIP] Cloud version support Cloud version support Jan 29, 2022
@paulotruta paulotruta merged commit 67a5444 into main Jan 29, 2022
@paulotruta paulotruta deleted the cloud_version_support branch January 29, 2022 19:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] Catch HTTP errors when communicating with API (open settings screen) [FEATURE] Storage Module Basis
2 participants