Enhance SVG parser. #740
Merged
Enhance SVG parser. #740
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…t and add some comment to explain the confusing logic.
(1) partial support <switch> (make it only displayable but not eval any conditions) (2) fix that: if fill and stroke use url (like fill:url(#someId)), the referred can be declared after the fill/stroke declared. (3) support gradientUnits (4) gradient can be declared without <defs>
# Conflicts: # src/graphic/Gradient.ts
pissang
approved these changes
Apr 7, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Enhance SVG parser.
Support SVG displayed by ZR element.
This feature is useful for upper application like echarts,
and make it possible to display SVG in some environment that not support SVG but only Canvas (like mini app).
Related PR apache/echarts#14571
Test cases
<zrender/test/parser-svg-cases.html>
Note: to run the cases, we need to put the project https://github.com/ecomfe/vis-data in the same directory of zrender.