Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check integrity of downloaded data files and avoid running dependent tests if a broken file is found. #41

Open
wants to merge 12 commits into
base: develop
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion INSTALL
Original file line number Diff line number Diff line change
Expand Up @@ -54,7 +54,7 @@ However if you wish to exercise more of the functionality of ecCodes, you are ad
> cmake ... -DENABLE_EXTRA_TESTS=ON

In this mode the tests will take longer and you need to be connected to the internet so data files can be downloaded
for the tests.
for the tests. Depending on the speed of your connection, downloading tests may timeout before completion. Then you may want to bump up 'TIMEOUT' parameter in DartConfiguration.tcl. If incomplete file is left behind after a timeout, downloading tests will continue to fail. You'll have to remove the corrupt file itself and the associated .localmd5 file to have download retried.

Also note that if you have several CPUs, you can invoke the "make" and "ctest" commands above in parallel
(e.g. "make -j4", "ctest -j4"). This will speed up the whole build/test process significantly.
Expand Down
5 changes: 3 additions & 2 deletions data/CMakeLists.txt
Original file line number Diff line number Diff line change
Expand Up @@ -16,8 +16,9 @@ endif()
if( ENABLE_EXTRA_TESTS )
# Download all data files
ecbuild_get_test_multidata( TARGET eccodes_download_gribs
NOCHECK
NAMES ${files_to_download} )
# NOCHECK
NAMES ${files_to_download} )
set_tests_properties( eccodes_download_gribs PROPERTIES FIXTURES_SETUP fixture_download_gribs )
endif()

# Copy other files - e.g. reference data, text files etc from the source data dir
Expand Down
6 changes: 4 additions & 2 deletions data/bufr/CMakeLists.txt
Original file line number Diff line number Diff line change
Expand Up @@ -12,14 +12,16 @@ file(READ "bufr_ref_files.txt" bufr_refs_to_download)
string(REGEX REPLACE "\n" ";" bufr_refs_to_download "${bufr_refs_to_download}")

# Exceptional case: download bufr files which have to be treated specially
list(APPEND bufr_refs_to_download "vos308014_v3_26.bufr") # See test ecc-197
list(APPEND bufr_refs_to_download "vos308014_v3_26.bufr:801bc5e9b9d887d45bdc1210a95afb9f") # See test ecc-197

if( ENABLE_EXTRA_TESTS )
ecbuild_get_test_multidata(
TARGET eccodes_download_bufrs
NOCHECK
# NOCHECK
NAMES ${bufr_files_to_download} ${bufr_refs_to_download}
)
set_tests_properties( eccodes_download_bufrs PROPERTIES FIXTURES_SETUP fixture_download_bufrs )

endif()

# Copy other files - e.g. text files etc from the source data/bufr dir
Expand Down
298 changes: 149 additions & 149 deletions data/bufr/bufr_data_files.txt
Original file line number Diff line number Diff line change
@@ -1,149 +1,149 @@
aaen_55.bufr
aben_55.bufr
ahws_139.bufr
airc_142.bufr
airc_144.bufr
airs_57.bufr
alws_139.bufr
amda_144.bufr
amsa_55.bufr
amsb_55.bufr
amse_55.bufr
amsu_55.bufr
amv2_87.bufr
amv3_87.bufr
asbh_139.bufr
asbl_139.bufr
asca_139.bufr
asch_139.bufr
ascs_139.bufr
aseh_139.bufr
asel_139.bufr
ashs_139.bufr
atap_55.bufr
ateu_155.bufr
atms_201.bufr
atov_55.bufr
avhm_87.bufr
avhn_87.bufr
avhr_58.bufr
b002_95.bufr
b002_96.bufr
b003_56.bufr
b004_145.bufr
b005_87.bufr
b005_89.bufr
b006_96.bufr
b007_31.bufr
bssh_170.bufr
bssh_176.bufr
bssh_178.bufr
bssh_180.bufr
btem_109.bufr
buoy_27.bufr
cmwi_87.bufr
cmwn_87.bufr
cnow_28.bufr
cori_156.bufr
crit_202.bufr
csrh_189.bufr
emsg_189.bufr
emsg_87.bufr
euwv_87.bufr
fy3a_154.bufr
fy3b_154.bufr
g2nd_208.bufr
g2to_206.bufr
go15_87.bufr
goee_87.bufr
goes_87.bufr
goga_89.bufr
gosat.bufr
grst_26.bufr
gsd1_208.bufr
gsd2_208.bufr
gsd3_208.bufr
gst4_26.bufr
hirb_55.bufr
hirs_55.bufr
ias1_240.bufr
iasi_241.bufr
ifco_208.bufr
ikco_217.bufr
itrg_208.bufr
itwt_233.bufr
j2eo_216.bufr
j2nb_216.bufr
jaso_214.bufr
kond_209.bufr
maer_207.bufr
meta_140.bufr
mhen_55.bufr
mhsa_55.bufr
mhsb_55.bufr
mhse_55.bufr
mloz_206.bufr
modi_87.bufr
modw_87.bufr
monw_87.bufr
nomi_206.bufr
nos1_208.bufr
nos2_208.bufr
nos3_208.bufr
nos4_208.bufr
nos5_208.bufr
nos6_208.bufr
nos7_208.bufr
nos8_208.bufr
ocea_131.bufr
ocea_132.bufr
ocea_133.bufr
ocea_21.bufr
pgps_110.bufr
pilo_91.bufr
rada_250.bufr
rado_250.bufr
s4kn_165.bufr
sb19_206.bufr
sbu8_206.bufr
ship_13.bufr
ship_19.bufr
ship_9.bufr
smin_49.bufr
smis_49.bufr
smiu_49.bufr
smos_203.bufr
sn4k_165.bufr
soil_7.bufr
ssbt_127.bufr
stuk_7.bufr
syno_1.bufr
syno_3.bufr
syno_4.bufr
syno_multi.bufr
synop_multi_subset.bufr
temp_101.bufr
temp_102.bufr
temp_106.bufr
tmr7_129.bufr
tros_31.bufr
wavb_134.bufr
207003.bufr
new.bufr
tropical_cyclone.bufr
uegabe.bufr
PraticaTemp.bufr
profiler_european.bufr
metar_with_2_bias.bufr
temp-land-with-substituted-values.bufr
imssnow.bufr
sentinel1.bufr
srals3_ecmwf4.bufr
srals3_eumetsat.bufr
eumetsat_iasi_co.bufr
eum_iasi_twt.bufr
delayed_repl_01.bufr
israel_observations_2017041010.bufr
goes16_nm.bufr
aeolus_wmo_26.bufr
ecc738.msg2.bufr
aaen_55.bufr:baabd2d4cc1411ab15f137b4777ca77f
aben_55.bufr:26154b965233fe7017e08b807def1846
ahws_139.bufr:3aeab657cbe29ebd4293d4af2ec0addf
airc_142.bufr:604380a436a096d61053f99005fcca28
airc_144.bufr:e0a238fbf7c9fb329c25c22ab0fafd9c
airs_57.bufr:b86b122009ee693a8bd3668b9f5d426e
alws_139.bufr:76134405b7a19bf1397ed79964408aa1
amda_144.bufr:71d69ad98818451cefd70bf652c0796f
amsa_55.bufr:03f5bbce0243dadd65171699ecb5d692
amsb_55.bufr:bbf287507d1f22713772076ecd49838a
amse_55.bufr:c93bfc4ec520bd219dd7f27897e00212
amsu_55.bufr:bbf3b237f03488647cb1721edb3837e8
amv2_87.bufr:a451216ad102d879386bdb8c9f141ab6
amv3_87.bufr:1ef1e111ccf660e05a6c972f5e69a623
asbh_139.bufr:7f8eac6f44468572bbc1d46eaa79225a
asbl_139.bufr:c6e9fb528a0a4a1f4b826be71aa18dea
asca_139.bufr:6e012c95269ad7c3c35b6b4215278f2c
asch_139.bufr:259514937e1281d24f77a4bc2696d422
ascs_139.bufr:d8d73dc6f20c14a7497a85be225baacc
aseh_139.bufr:94f00636ee8ae7036e14fdf553951cbb
asel_139.bufr:d2f51042d64181c43862a6d9ea1eb94c
ashs_139.bufr:959e07d42f681a8d556292f403149cd6
atap_55.bufr:d667cb249632d68e2a87e789824f6e52
ateu_155.bufr:aa59e8250b6c305b17374c9fac98c5cb
atms_201.bufr:f568f098c453533f0b1dda95fc5448ec
atov_55.bufr:3c9cdb2d82327f9e1027b43c3b1a9e59
avhm_87.bufr:2880abac2a57d03d07d8e93ecbe85f93
avhn_87.bufr:ec0eba15bfc5f5b2aff5608646862075
avhr_58.bufr:9cd3f57d0007a449c16424dc9c9b2b43
b002_95.bufr:b39262893ca1cf060609c868ef4f6bf7
b002_96.bufr:48c252818f5cc35fa4fe6bcd743bd70f
b003_56.bufr:bf65110537629d7bab98733c69d7a7cd
b004_145.bufr:b84dbf4b8f155bdd858135096c56edaa
b005_87.bufr:55e4ccbbf31c42acab10d7ff3c3ebf6b
b005_89.bufr:6f24c980e56ac3f4a4799eb84e9a35d8
b006_96.bufr:13a5e9a735a1463e0c2be8f609daa3b4
b007_31.bufr:4c26b87de3d886b2117bb3390a125340
bssh_170.bufr:ce213312a256747f64ce41589631415c
bssh_176.bufr:ededde0cdf383ec7e1556fa8dc3c457f
bssh_178.bufr:c8f0e0db3c212b9c9678cd0c4782d08b
bssh_180.bufr:a35272797d063978704c60a03241291f
btem_109.bufr:6ced0f802b8c13507708ccbc0bd6dc59
buoy_27.bufr:4ff9637cbd945b072e3cb2ec11a7dfdd
cmwi_87.bufr:28b057f37f9f7fc17e7baa4d2fc3a36e
cmwn_87.bufr:32975323403bdc03f9f3f9d5cf3820f9
cnow_28.bufr:b5df2c28899f6672e539f9030dddf019
cori_156.bufr:4db4e174a3962201ae5db952b5144bef
crit_202.bufr:212f31335a9f0e22fa116bdacdfd431b
csrh_189.bufr:f809b5213cd206981623e07fb9863d93
emsg_189.bufr:a4d1957af6c5e514ae09293794774d63
emsg_87.bufr:935d15a41f2edafdb94adae093b3643c
euwv_87.bufr:22eee2f1cd6b54b77e6875707ed4d0eb
fy3a_154.bufr:0ea1a55e220d97a476b5b8b178c5c761
fy3b_154.bufr:7a50acef12ad83d6fc56ec3ec20fce55
g2nd_208.bufr:baa96963b3161e215590228fbf1e6dd2
g2to_206.bufr:c168cb289a265759ba10f04975b2bce7
go15_87.bufr:2215f60788d922d7da08522cfe95fa67
goee_87.bufr:1deadc72d85d01da8ec317f8343f3ad3
goes_87.bufr:2efa1ac35a08bd7723fc26d6c16ba247
goga_89.bufr:ab2e42ee85d7100e450cec261eafe6aa
gosat.bufr:8449d15ca468c7ecdf38c0e97bb183f8
grst_26.bufr:93cf0129c2e5355fca1c6b1fe8ffe6fc
gsd1_208.bufr:e5a8943a3391f33cc999e45d8a0dd919
gsd2_208.bufr:abd6b73b02b5e57ae3492297789af79b
gsd3_208.bufr:3dccb8bc2ec70cc8af24e819b3da99c5
gst4_26.bufr:0c84d8f53e1dbec4406943ccd70b00e5
hirb_55.bufr:08fd4f1d15f01b2bd3b5fd1b6f411b93
hirs_55.bufr:912ebbc1496406f60b68d506be5efac2
ias1_240.bufr:098e147fb7cd8c962318c22bdaa6ec07
iasi_241.bufr:b6a7d14963690aaf9e8f6b639c0981c0
ifco_208.bufr:484a4425f640a467de4e81f57291f1ad
ikco_217.bufr:890b622d06a740f86cffcc4e5f10cedc
itrg_208.bufr:874f38bb210e21ce69c1fb4599ee40af
itwt_233.bufr:3f8dc1e9a1cc8087bb941955e0a91a45
j2eo_216.bufr:e1131afd5bb2ebf4c357471b8e0fe5ec
j2nb_216.bufr:86b80784f467d61e43f9d1f1d1091293
jaso_214.bufr:a911878ac458163f5207c4a26b7e01ef
kond_209.bufr:26a27774601c62306d79af6f5783e885
maer_207.bufr:5912615bea511535ba2dd4684c37f4bc
meta_140.bufr:842e5dd713029ae636adf836d5cf9142
mhen_55.bufr:0cbdd48a283088bb2402b9eb0527bc0a
mhsa_55.bufr:75cb48b512890fdca3bbb2667355e28b
mhsb_55.bufr:fda59da064dba195ee410d8191d2235b
mhse_55.bufr:f25f9792fe89d6476869f6e9c5bf7485
mloz_206.bufr:b64d308592b3da6d99af8dd3f4d8b443
modi_87.bufr:4d16db61a8108dfd05ee5df0860a409f
modw_87.bufr:51d51e15119d2f2f01c48d7f19eeb14e
monw_87.bufr:6c5762a480be19c8962dc4e06a6dd374
nomi_206.bufr:56aa0b041b39a469dd50d31ee0935d95
nos1_208.bufr:021e72b1c8b3fa8c4527bfb526116dc6
nos2_208.bufr:9fe12643605908622cb265f94994e8b0
nos3_208.bufr:5ac37e1d159fe0e277c490190d9f7b0f
nos4_208.bufr:d2e21dc35a0d8072ca7afd859ce4f444
nos5_208.bufr:8716b29716436389264e9184ffdf4d1f
nos6_208.bufr:2fb8b0371ce75e45cb62e7ce0d768e36
nos7_208.bufr:c702cef1bba628d8a9c44a6d833f1d7f
nos8_208.bufr:beeeaab7d5c4ef62ed479e93c7aee36b
ocea_131.bufr:7fa8e1baf8fcec5900e0b0cd7c384265
ocea_132.bufr:34bc5bb464bee9e4107f9d1b061829d1
ocea_133.bufr:201e49145c6658307718ff6c2e8748c2
ocea_21.bufr:d3c472fea14af99b2e9241d4a6a9c9fc
pgps_110.bufr:58d491f480b7477b0d968968c1001cfd
pilo_91.bufr:58e54d2e5f2ff3f37cdf38ab0cd1eb00
rada_250.bufr:f1b0892fdafc919a28bf277be16a899c
rado_250.bufr:c6a135db5d20932226fbc2de5b74b465
s4kn_165.bufr:cd37897fe74d90a574987f2bd4c14830
sb19_206.bufr:40c6a2202812610ed5fa672947ce1d04
sbu8_206.bufr:7ea7a11f6ef91cd6b7e2c59b6164e7cd
ship_13.bufr:71c327a9900942e321f6c826a7f9429b
ship_19.bufr:0ef29702e79de8dfc3c2185c6138b81f
ship_9.bufr:2767e6dbbd195bc01169028cbda964d6
smin_49.bufr:7e2dd3583a1f829a2c52ba7c76e025f2
smis_49.bufr:c70d060a30cb796d0bd9095aa632bb08
smiu_49.bufr:4017c1ea017df319c50666f7221dd344
smos_203.bufr:8e031868086f245f7e853af7f3872969
sn4k_165.bufr:889a99b05aacd5dcbfe73b00b54892d1
soil_7.bufr:df091a6b368e167ecb1b2acdb2a88f4c
ssbt_127.bufr:2e3c87af64949d197516c4857ca571d6
stuk_7.bufr:c1bc2979e6091e2d12970f1c8059fcf6
syno_1.bufr:24e807da05dbbdcf0597c80ab712d3ba
syno_3.bufr:971066296cdcab3e2edf4941f2b52a1d
syno_4.bufr:e2f332816c26f48d80c4a4837fd01c4f
syno_multi.bufr:fe0c9eae14503fd5af1e2ce7f0befdd6
synop_multi_subset.bufr:8ff9135117f121ae858b5fed43a9da29
temp_101.bufr:8e462d191660f93a7237d1ec13048058
temp_102.bufr:4b1b46a0ab1500a578a7eb36bf69d80c
temp_106.bufr:a2616bafb4b8fdd7dfb9f42901940465
tmr7_129.bufr:761971eb3012af18c78a5f29c860b74e
tros_31.bufr:9a61ca23e12535c639ffbad3c2688dd0
wavb_134.bufr:f0607623749f645236346ba75fb91308
207003.bufr:55bb4ee9d54ec6f16a305b61afb0dfc0
new.bufr:2d49cd327cd1e6b5793ee2c02b6dfc45
tropical_cyclone.bufr:c172dc59294516480cc8b10112cf9c73
uegabe.bufr:77154a7f9a7b50a621edc70f950cd1b5
PraticaTemp.bufr:c04244c8f7dc2905d0bcdaca6f30a259
profiler_european.bufr:719e8f1d7922ffa59de9f6b54ab050dc
metar_with_2_bias.bufr:f0e6dbf024a1d9f9636983b21576a1f5
temp-land-with-substituted-values.bufr:a271044b514efadcb2684d9920f1deae
imssnow.bufr:0ffac3105f62ad308988ba4bcc5cae4b
sentinel1.bufr:c48d90996b678608786b2cc7414c4734
srals3_ecmwf4.bufr:9b3ffacaa4f566ff62157be627ade0f8
srals3_eumetsat.bufr:a8bec4c19fc7712589f3fcb7af1f5fbd
eumetsat_iasi_co.bufr:b681c88a4d15cfd3eece885f5f1c3100
eum_iasi_twt.bufr:f17dd057f15c90601715cd88ec2b5fec
delayed_repl_01.bufr:a0526d5092f6407642814827c1c1c372
israel_observations_2017041010.bufr:b2a3deacb76b81a0997eacfc4387a676
goes16_nm.bufr:971581da8747fc45edb325201c657c6c
aeolus_wmo_26.bufr:b6d6f24df409f614d985b87d4f59c3f9
ecc738.msg2.bufr:551af85232ed11a802c674f5aa7b2401
Loading