Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP: Check file-size of test-data in tests #40

Closed
wants to merge 3 commits into from

Conversation

shinji-s
Copy link
Contributor

I spent fair amount of time trying to diagnose cause of a few failed ctest cases. The culprit turned out to be incomplete 'test.grib1' file. (At another time, the culprit was syno_1.burf.num.ref) Since the file downloading performed by the ecbuild cmake rule attempts by default no retries and keeps partially downloaded files laying around, possibility of this happening to other developers is not slim. It is better to flag the problem explicitly rather than having tests mysteriously fail. Perhaps ECBUILD_DOWNLOAD_RETRIES parameter also need to be tweaked for more robust downloading.

@shinji-s
Copy link
Contributor Author

A better solution would be to declare data downloading tests to be fixtures and make them check the file size. But I guess it would requires more laborious work and wider changes.

@shinji-s shinji-s changed the title Check file-size of test-data in tests WIP: Check file-size of test-data in tests Aug 14, 2020
@shinji-s
Copy link
Contributor Author

I'm looking into that solution. Please hold the merge for now.

@shinji-s
Copy link
Contributor Author

if( ENABLE_EXTRA_TESTS )
    # Download all data files
    ecbuild_get_test_multidata( TARGET eccodes_download_gribs
                            NOCHECK
                            NAMES ${files_to_download} )
endif()

Integrity checking provided by the ecbuild is explicitly disabled by eccodes.
Why is it?

@shahramn
Copy link
Collaborator

I'm looking into that solution. Please hold the merge for now.

I am on my holidays so no rush re merging. Take your time. And many thanks for all your good work. Much appreciated

@shinji-s
Copy link
Contributor Author

Noted. Thank you for the follow up. Please enjoy the rest of your holidays.

@shinji-s
Copy link
Contributor Author

Closing in favor of #41.

@shinji-s shinji-s closed this Aug 18, 2020
@shinji-s shinji-s deleted the check_fsize_in_tests branch November 16, 2020 12:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants