WIP: Check file-size of test-data in tests #40
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I spent fair amount of time trying to diagnose cause of a few failed ctest cases. The culprit turned out to be incomplete 'test.grib1' file. (At another time, the culprit was syno_1.burf.num.ref) Since the file downloading performed by the ecbuild cmake rule attempts by default no retries and keeps partially downloaded files laying around, possibility of this happening to other developers is not slim. It is better to flag the problem explicitly rather than having tests mysteriously fail. Perhaps ECBUILD_DOWNLOAD_RETRIES parameter also need to be tweaked for more robust downloading.