Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix multiple free in destroy@action_class_concept.c #39

Merged
merged 4 commits into from
Aug 25, 2020

Conversation

shinji-s
Copy link
Contributor

Pointers to concept_value in the trie are borrowed pointers, which should not be free'd.)

@shinji-s
Copy link
Contributor Author

Attaching code to reproduce the problem, which was taken from #25.
Valgrind log is also attached.

writeindex.c.gz
valgrind.log.gz

@shahramn
Copy link
Collaborator

Looks like there's a problem with Travis CI. I am trying to merge your PR but the builds are stalled

@shinji-s
Copy link
Contributor Author

Yes currently github fails to receive response from Travis CI. That needs to be fixed though test results can be viewed at https://travis-ci.org/github/ecmwf/eccodes.

Minor change to kick off Travis again so I can merge this PR
@shahramn shahramn merged commit bf2aa48 into ecmwf:develop Aug 25, 2020
@shinji-s
Copy link
Contributor Author

You fixed travis-ci integration issue? Cool!

@shahramn
Copy link
Collaborator

You fixed travis-ci integration issue? Cool!

I had to make a minor change just to kick off Travis. And it worked!!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants