Remove redundant conditionals and an assignment. #34
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
|
Can you please provide a test case that demonstrates the problem |
|
There is no logical problem in the code. Hence I can think of no appropriate test cases that demonstrate any problem. This PR is about code clarity.
|
|
Closing as this PR is superceded by #51. |
FussyDuck
pushed a commit
that referenced
this pull request
Aug 1, 2022
Merge in ECCODES/eccodes from bugfix/ECC-1431-CCSDS-OutputBufferSize to develop * commit '7374409c4706ad099a8d76de5e34e9d53369a5c0': ECC-1431: Simplified test ECC-1431: Fix loop initialization ECC-1431: Limit test values to the range of float ECC-1431: Minor changes ECC-1431: Add failed condition ECC-1431: Adding missing set function ECC-1431: Build test only if C++ enabled ECC-1431: Minor fix ECC-1431: Test ECC-1431: Test language changed from .c to .cpp ECC-1431: Preparations for testing ECC-1431: Simplified output buffer size formula ECC-1431: Fixed output buffer size
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Breaking out of the while loop and falling through guarantees that 'gm' is NULL.
!c->multi_support is equivalent to prev==NULL.