Propagate const char* for codes/grib_index_new_from_file and codes/grib_index_select_string #33
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Propagate const char* value for codes/grib_index_select_string.
|
|
|
Thank you for your contribution |
FussyDuck
pushed a commit
that referenced
this pull request
Nov 30, 2021
Merge in ECCODES/eccodes from ~MADV/eccodes:feature/reusable-workflows to develop * commit '12313501fc9b120e807227d1fafa349b2b867fe6': Switched to reusable workflow.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change has no functional impact.
The goal is to clarify intent and simplify interfacing with C++ for the aforementioned functions. This allows using e.g. string literals or
std::stringin a straight-forward manner without having to cast away the const.