Add Windows support for building with CMake #3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I think the context makes it obvious that these changes are for MSVS.
Lets the examples work on Windows.
random() doesn't exist on Windows.
Lets us pass the `--strip-trailing-cr` option to `diff` on Windows without changing the Unix tests.
uint64_t is defined in stdint.h on Windows.
|
|
Moved from ecBuild so the suppressions are project-specific.
jom is an nmake clone with a -j option.
This was causing a macro redefinition warning for those building with Visual Studio instead of cmake.
So it's the same as on non-Windows
So _findfirst actually works.
There's no directory check in the non-Windows code.
jom seems to be causing intermittent build failures. That's no good.
It's making unsafe changes.
dtip
force-pushed
the
dtip-windows
branch
2 times, most recently
from
400b628
to
6e71897
Compare
This is more straightforward than manually changing the system path.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
One important thing to note is that the AppVeyor CI currently depends on the dtip-windows branch of ecBuild. Once the ecBuild changes are in develop, we need to change the branch. If the ecBuild PR is merged before this one I'll make the change here.