Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ecCodesMIA 2.17.0 b6 #28

Closed
wants to merge 14 commits into from
Closed

Conversation

teresanoviello
Copy link

  1. The motivation of the change and impact on code:
    This is the ecCodesMIA B6 version, also referred to as 'Reduction of mallocs: introducing static memory area in dynamic arrays'.
    This is a pull request for a branch derived from ecCodes official repository, tag "2.17.0": so please, when merging take into account to not do it against the current ecCodes "develop" HEAD.
    The complete changes applied are described in the file "src/ChangesB6.txt".
    This code is not operational. Impacts on the code: NOT all automated tests are passing, the complete output is in the file "ctest3.out". This output is also mentioned ad the confluence page 'https://confluence.ecmwf.int/x/bAA1Cw'.
    A full report of the ecCodesMIA project is accessible at https://gitlab.eumetsat.int/additional-data-services/eccodes-impact-analysis/-/blob/master/docs/officialdocs/ecCodesMIA_FinalReport_files/ecCodesMIA_FinalReport.md.

  2. The author of changes accepts the "ECMWF Contributors License Agreement".
    In particular:
    2.1. This code can be redistributed under Apache License 2.0;
    2.2. This code doesn't violate anyone IPR' rights;

3.Exception to PR requirements as described in "https://confluence.ecmwf.int/display/SUP/ECMWF+software+on+GitHub":
3.1. Although this code passes most of the automated and regression tests, it is not intended as an operational version, as stated earlier.

@FussyDuck
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.
1 out of 2 committers have signed the CLA.

✅ shahramn
❌ Teresa Noviello


Teresa Noviello seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.
You have signed the CLA already but the status is still pending? Let us recheck it.

…ry area in dynamic arrays. File src/ChangesB6.txt contains version description. File ctest3.out contains automated tests complete report.
@teresanoviello
Copy link
Author

Closing this PR request.
I think the fastest way is to remove these PRs and I can just submit them again. I think it would work because:

"[email protected]" is now in my GitHub account;
I would be tidy and sign the new CLA with email "[email protected]"

1 similar comment
@teresanoviello
Copy link
Author

Closing this PR request.
I think the fastest way is to remove these PRs and I can just submit them again. I think it would work because:

"[email protected]" is now in my GitHub account;
I would be tidy and sign the new CLA with email "[email protected]"

shinji-s pushed a commit to shinji-s/eccodes that referenced this pull request Jul 25, 2020
…ck_update to develop

* commit '430a6b1537426cbd5ada85af17205c1ee58557e4':
  s2s ocean o2d update u/v currents as per ECC-1013
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants