Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ECC-1850: Extended metadata keys along with corresponding test #222

Merged
merged 2 commits into from
Jun 26, 2024

Conversation

mjg41
Copy link
Collaborator

@mjg41 mjg41 commented Jun 26, 2024

After a discussion with modelling partners at BSC who will also contribute to EERIE it was clear several keys used in the DestinE ClimateDT layout would be useful within the context of the EERIE data layout.
Therefore we will add the keys generation, model and resolution to the EERIE data layout (localTemplateNumber 43), taking the same values as within the ClimateDT.
This has been agreed as an acceptable change with those involved with EERIE given that this will produce better synergies in the future with other datasets and allow the same processing pipelines to be used. Previous GRIB fields with centre 98, local def 43 will have to be DISCARDED.

@mjg41 mjg41 requested a review from shahramn June 26, 2024 14:49
@mjg41 mjg41 self-assigned this Jun 26, 2024
@shahramn shahramn self-assigned this Jun 26, 2024
@shahramn shahramn added the approved-for-ci Approved to run CI on ECMWF machines label Jun 26, 2024
Copy link

Private downstream CI failed.
Workflow name: private-downstream-ci-hpc
View the logs at https://github.com/ecmwf-actions/private-downstream-ci/actions/runs/9682620430.

@shahramn shahramn merged commit 38d7f8b into develop Jun 26, 2024
151 of 154 checks passed
@shahramn shahramn deleted the feature/ECC-1850-EERIE-extension branch June 26, 2024 16:03
Copy link

Private downstream CI succeeded.
Workflow name: private-downstream-ci
View the logs at https://github.com/ecmwf-actions/private-downstream-ci/actions/runs/9683003621.

Copy link

Private downstream CI succeeded.
Workflow name: private-downstream-ci
View the logs at https://github.com/ecmwf-actions/private-downstream-ci/actions/runs/9683323405.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved-for-ci Approved to run CI on ECMWF machines
Projects
None yet
2 participants