Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP: Get more of the extended tests to pass on Windows #22

Closed
wants to merge 92 commits into from
Closed
Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
92 commits
Select commit Hold shift + click to select a range
d49a7e8
Remove trailing whitespace
dtip Dec 10, 2019
5e57e7b
CI: get libnetcdf from conda-forge
dtip Dec 12, 2019
49c0242
Attempt to debug netcdf.dll location
dtip Dec 12, 2019
cfc210c
ECC-499 and Windows test eccodes_t_grib_ecc-979
shahramn Dec 13, 2019
2ab1794
ECC-499 and Windows test eccodes_t_grib_ecc-979
shahramn Dec 13, 2019
4c2ae02
Fix mistyped `find` command
dtip Dec 13, 2019
a764686
Debug with ntldd
dtip Dec 13, 2019
ee1462d
Check PATH before running tests
dtip Dec 13, 2019
d62ba21
Testing: Don't compare doubles with 10 decimal places
shahramn Dec 16, 2019
4c1660e
Windows: Use stat rather than fstat
shahramn Dec 16, 2019
c2ba865
Tests: grib_nearest
shahramn Dec 16, 2019
ed1c13c
Testing: show diff results when they fail
shahramn Dec 16, 2019
9f1c584
Testing: Windows diff dumps
shahramn Dec 16, 2019
2b60111
Windows: Fix BUFR decode (long vs size_t) (Part 1)
shahramn Dec 16, 2019
dd02312
Windows: Fix BUFR decode (long vs size_t) (Part 2)
shahramn Dec 17, 2019
4f1cf21
Windows: Fix BUFR encode (long vs size_t) (Part 3)
shahramn Dec 17, 2019
d8554cd
Windows: Add relative tolerance for BUFR compare
shahramn Dec 17, 2019
1a45670
Windows: Increase relative tolerance for BUFR compare
shahramn Dec 17, 2019
528f31d
Debug test env
dtip Dec 18, 2019
012f5d5
Use %CONDA% instead of %CONDA_PREFIX%
dtip Dec 18, 2019
e361d1d
Check /bin for netcdf.dll
dtip Dec 18, 2019
0b6eb51
Debug bash location
dtip Dec 18, 2019
36ae21b
Attempt to fix missing netcdf.dll
dtip Dec 18, 2019
adfca52
Check contents of /usr/bin
dtip Dec 18, 2019
17e9076
More ntldd
dtip Dec 18, 2019
9f3dac5
Latest changes from develop
shahramn Dec 18, 2019
3e95ed7
ECC-1045: GRIB1: Local definition 5: Allow lowerThreshold and upperTh…
shahramn Dec 19, 2019
c6a804b
Windows: BUFR encoding (no need to #define 'round')
shahramn Dec 23, 2019
884aea3
Resolve tests/grib_to_netcdf.sh conflict
shahramn Dec 23, 2019
b5dd3c7
Windows: re-enable tests
shahramn Dec 23, 2019
fd95cef
ECC-1045: add test
shahramn Dec 23, 2019
11f3725
Windows: BUFR encoding (eccodes_t_bufr_dump_encode_filter)
shahramn Dec 24, 2019
63695e2
Tests: Print out norm on failure
shahramn Dec 24, 2019
dad45e7
Tools: check if input paths are directories
shahramn Dec 27, 2019
24c96fd
Windows: The 'round' function is now supported (since 2017)
shahramn Dec 27, 2019
20c5829
Tests: check bufr_compare input path and cleanup
shahramn Dec 27, 2019
e8af13f
Latest updates from develop
shahramn Dec 30, 2019
5ce096e
Merge branch 'develop' into windows-bugfixes
dtip Jan 6, 2020
77d4521
Re-enable failing windows tests
shahramn Jan 6, 2020
6a58685
Fix failing test eccodes_t_bufr_ecc-197
shahramn Jan 6, 2020
494a9a4
Add netcdf.dll location to $PATH for testing
dtip Jan 6, 2020
828cfea
Remove debug and failed attempts to put netcdf.dll in path
dtip Jan 6, 2020
25d64cd
Latest updates from develop
shahramn Jan 7, 2020
888ed8a
Latest updates from develop (2)
shahramn Jan 9, 2020
8c9c997
Latest updates from develop (3)
shahramn Jan 10, 2020
455d05f
Windows: Fix test failure (eccodes_t_grib_data_quality_checks)
shahramn Jan 10, 2020
dabe970
Github: Trigger Travis build
shahramn Jan 10, 2020
0f5dfa4
ECC-1018
shahramn Jan 10, 2020
d730375
Latest updates from develop (4)
shahramn Jan 16, 2020
4401127
Merge branch 'develop' into windows-bugfixes
shahramn Jan 16, 2020
f3abc0f
Latest updates from develop (5)
shahramn Jan 17, 2020
dbb3b0f
Latest updates from develop (6)
shahramn Jan 24, 2020
25fd0c9
Latest updates from develop (7)
shahramn Jan 27, 2020
73174e1
Latest updates from develop (8)
shahramn Jan 28, 2020
3ccfdb2
Latest updates from develop (9)
shahramn Jan 29, 2020
d628be2
Latest updates from develop (10)
shahramn Feb 6, 2020
9fecfd3
Latest updates from develop (10)
shahramn Feb 6, 2020
681a128
Merge branch 'develop' into windows-bugfixes
shahramn Feb 6, 2020
6b2bc13
Latest updates from develop (11)
shahramn Feb 6, 2020
fa7669b
Latest updates from develop (12)
shahramn Feb 7, 2020
0f33a73
Latest updates from develop (13)
shahramn Feb 10, 2020
15f3612
Latest updates from develop (14)
shahramn Feb 10, 2020
99d7720
Latest updates from develop (15)
shahramn Feb 11, 2020
3117854
Latest updates from develop (16)
shahramn Feb 17, 2020
205f6c9
Merge branch 'develop' into windows-bugfixes
shahramn Feb 17, 2020
80c3ad7
Latest updates from develop (17)
shahramn Feb 19, 2020
85e9be2
Merge branch 'develop' into windows-bugfixes
shahramn Feb 19, 2020
1067571
Latest updates from develop (18)
shahramn Feb 20, 2020
c0b2aa6
Latest updates from develop (19)
shahramn Feb 21, 2020
5870baa
AppVeyor notifications
shahramn Feb 21, 2020
9816b5b
Merge branch 'develop' into windows-bugfixes
shahramn Feb 21, 2020
4166bdb
AppVeyor notifications: print branch
shahramn Feb 21, 2020
97efc46
Latest updates from develop (20)
shahramn Feb 24, 2020
e42ca87
AppVeyor notifications
shahramn Feb 24, 2020
a72aeaa
Latest updates from develop (21)
shahramn Feb 24, 2020
ebc65ac
Latest updates from develop (22)
shahramn Feb 27, 2020
8ad0bb1
Merge branch 'develop' into windows-bugfixes
shahramn Feb 27, 2020
5ac99ab
Latest updates from develop (23)
shahramn Mar 2, 2020
7ca3e9c
Merge branch 'windows-bugfixes' of https://github.com/dtip/eccodes in…
shahramn Mar 2, 2020
86bafd3
Merge branch 'develop' into windows-bugfixes
shahramn Mar 2, 2020
115c655
Latest updates from develop (24)
shahramn Mar 3, 2020
bff210a
Latest updates from develop (25)
shahramn Mar 11, 2020
42a0974
Add debug to see why tests fail
shahramn Mar 12, 2020
8b1c6df
Add debug to see why tests fail (2)
shahramn Mar 13, 2020
d358576
Add debug to see why tests fail (3)
shahramn Mar 13, 2020
c1fbfd5
Fix broken tests (samples path)
shahramn Mar 13, 2020
bb6e8e6
Latest updates from develop (26)
shahramn Mar 18, 2020
76cbb1b
Latest updates from develop (27)
shahramn May 16, 2020
8161ac2
Resolve conflicts: VERSION.cmake
shahramn May 16, 2020
37154b2
Renamed test files
shahramn May 16, 2020
9b038da
Latest updates from develop (28)
shahramn May 17, 2020
b84bf73
Merge branch 'develop' into windows-bugfixes
shahramn May 17, 2020
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Re-enable failing windows tests
  • Loading branch information
shahramn committed Jan 6, 2020
commit 77d4521caeeda79fc07fb959fd98b5c0e9f4c344
5 changes: 0 additions & 5 deletions examples/C/bufr_copy_data.sh
Original file line number Diff line number Diff line change
Expand Up @@ -12,11 +12,6 @@
#Define a common label for all the tmp files
label="bufr_copy_data_c"

if [ $ECCODES_ON_WINDOWS -eq 1 ]; then
echo "$0: This test is currently disabled on Windows"
exit 0
fi

TEMP_BUFR=$label.out.bufr
TEMP_TEXT=$label.out.txt
REF=$label.compare.log.ref
Expand Down
2 changes: 1 addition & 1 deletion tests/CMakeLists.txt
Original file line number Diff line number Diff line change
Expand Up @@ -299,7 +299,7 @@ endif()

ecbuild_add_test( TARGET eccodes_t_grib_to_netcdf
TYPE SCRIPT
CONDITION HAVE_NETCDF AND ENABLE_EXTRA_TESTS AND NOT ECCODES_ON_WINDOWS
CONDITION HAVE_NETCDF AND ENABLE_EXTRA_TESTS
COMMAND ${CMAKE_CURRENT_SOURCE_DIR}/grib_to_netcdf.sh
TEST_DEPENDS eccodes_download_gribs
)
Expand Down
2 changes: 0 additions & 2 deletions tests/Makefile.am
Original file line number Diff line number Diff line change
Expand Up @@ -43,7 +43,6 @@ TESTS = definitions.sh \
grib_compare.sh \
grib_level.sh \
index.sh \
grib_bitmap.sh \
grib_list.sh \
grib_second_order.sh \
grib_change_scanning.sh \
Expand All @@ -61,7 +60,6 @@ TESTS = definitions.sh \
grib_ccsds.sh \
md5.sh \
grib_neg_fctime.sh \
bufr_ecc-197.sh \
bufr_ecc-286.sh \
bufr_ecc-288.sh

Expand Down
17 changes: 12 additions & 5 deletions tests/bufr_ecc-197.sh
Original file line number Diff line number Diff line change
Expand Up @@ -18,13 +18,20 @@
label="bufr_ecc-197-test"

input=${data_dir}/bufr/vos308014_v3_26.bufr
if [ ! -f $input ]; then
echo "Data file $input not available"
exit 0
fi
TEMP=${label}.temp
LOG=${label}.log


# Get expanded descriptors
cat > $TEMP <<EOF
print "expandedDescriptors=[expandedDescriptors%06d!0]";
EOF
${tools_dir}/bufr_filter -f $TEMP $input > $LOG 2>&1
grep -q "ECCODES ERROR.*no match for sequences=308014" $LOG


# Create a temporary directory which holds the tables etc
# This BUFR file uses masterTablesVersionNumber 26
TEMP_DIR=${label}.temp-dir.$$
rm -rf $TEMP_DIR
mkdir -p $TEMP_DIR/definitions/bufr/tables/0/wmo/26
Expand All @@ -47,4 +54,4 @@ set `wc -l $TEMP`
[ $1 -gt 35700 ]

rm -rf $TEMP_DIR
rm -f $TEMP
rm -f $TEMP $LOG