Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Relaxation of the "Step Units Rule" #218

Merged
merged 3 commits into from
Jun 11, 2024

Conversation

joobog
Copy link
Collaborator

@joobog joobog commented Jun 11, 2024

https://jira.ecmwf.int/browse/ECC-1802

The updated rule permits simultaneous assignment of the same step unit to both 'stepUnits' and 'step*' keys, e.g., grib_set -s stepUnits=s,step=11s $in $temp

@shahramn shahramn added the approved-for-ci Approved to run CI on ECMWF machines label Jun 11, 2024
Copy link

Private downstream CI failed.
Workflow name: private-downstream-ci-hpc
View the logs at https://github.com/ecmwf-actions/private-downstream-ci/actions/runs/9463727511.

Copy link

Private downstream CI succeeded.
Workflow name: private-downstream-ci
View the logs at https://github.com/ecmwf-actions/private-downstream-ci/actions/runs/9463702540.

@codecov-commenter
Copy link

Codecov Report

Attention: Patch coverage is 75.00000% with 1 line in your changes missing coverage. Please review.

Project coverage is 86.53%. Comparing base (ca0c5f1) to head (6197097).

Files Patch % Lines
src/step.cc 75.00% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff            @@
##           develop     #218   +/-   ##
========================================
  Coverage    86.53%   86.53%           
========================================
  Files          786      786           
  Lines        62886    62888    +2     
  Branches     11070    11071    +1     
========================================
+ Hits         54416    54418    +2     
  Misses        8470     8470           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@shahramn shahramn merged commit 57026bc into develop Jun 11, 2024
323 of 325 checks passed
@shahramn shahramn deleted the feature/ecc-1802_relax_stepunits_rule branch June 11, 2024 11:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved-for-ci Approved to run CI on ECMWF machines
Projects
None yet
3 participants