Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update ci.yml to fix notification #217

Merged
merged 1 commit into from
Jun 7, 2024
Merged

Conversation

geier1993
Copy link
Contributor

The notify step was skipped on failing jobs because the always() was not handled properly. Instead of always() && ${{ ... }} we have to pull in the always ${{ always() && .. }}

The notify step was skipped on failing jobs because the `always()` was not handled properly. Instead of `always() && ${{ ... }}` we have to pull in the always `${{ always() && .. }}`
@FussyDuck
Copy link

FussyDuck commented Jun 7, 2024

CLA assistant check
All committers have signed the CLA.

@shahramn shahramn self-assigned this Jun 7, 2024
@shahramn shahramn requested a review from iainrussell June 7, 2024 09:38
@shahramn shahramn added the approved-for-ci Approved to run CI on ECMWF machines label Jun 7, 2024
@shahramn shahramn merged commit fda9677 into develop Jun 7, 2024
303 of 307 checks passed
@shahramn shahramn deleted the fix/ci-notifications-to-teams branch June 7, 2024 10:50
Copy link

github-actions bot commented Jun 7, 2024

Private downstream CI failed.
Workflow name: private-downstream-ci-hpc
View the logs at https://github.com/ecmwf-actions/private-downstream-ci/actions/runs/9415809354.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved-for-ci Approved to run CI on ECMWF machines
Projects
None yet
3 participants