Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

https://jira.ecmwf.int/browse/ECC-1806 #205

Merged
merged 6 commits into from
Apr 20, 2024

Conversation

shahramn
Copy link
Collaborator

@shahramn shahramn self-assigned this Apr 19, 2024
@shahramn shahramn added the approved-for-ci Approved to run CI on ECMWF machines label Apr 19, 2024
@codecov-commenter
Copy link

codecov-commenter commented Apr 20, 2024

Codecov Report

Attention: Patch coverage is 80.00000% with 2 lines in your changes are missing coverage. Please review.

Project coverage is 87.51%. Comparing base (f13b2af) to head (403ef58).
Report is 2 commits behind head on develop.

Files Patch % Lines
src/grib_accessor_class_concept.cc 80.00% 2 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff            @@
##           develop     #205   +/-   ##
========================================
  Coverage    87.50%   87.51%           
========================================
  Files          564      564           
  Lines        59235    59247   +12     
========================================
+ Hits         51835    51849   +14     
+ Misses        7400     7398    -2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@shahramn shahramn merged commit 302c88b into develop Apr 20, 2024
57 of 65 checks passed
@shahramn shahramn deleted the feature/ECC-1806-paramIdConversion branch April 20, 2024 21:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved-for-ci Approved to run CI on ECMWF machines
Projects
None yet
2 participants