Improvement on file spliting

[wqu-bom]

Allow an input file to be split into each individual message (if nchunk=-1)

[FussyDuck]

All committers have signed the CLA.

[shahramn]

Thank you. Have you included tests?
Please see: tests/codes_split_file.sh

[shahramn]

Thank you for the test. By the way have you signed the Contributor License Agreement?

[dtip]

Hi chaps. Can I suggest you switch the osx_image in .travis.yml to xcode10.2? That may fix the MacOS build issue.

[shahramn]

Thanks Daniel. I will change it and push to develop

[wqu-bom]

I have not signed the CLA. I have tried a few links and it did not work. Please advise how to or email me a form that I can sign and send back to you. Thanks.

[StephanSiemen]

Hi @wqu-bom,
I signed the code agreement fine (see comment above). The system uses email addresses to identify users and contributions. The system relies on you using the same email address for the GIT checkins and the GitHub account. Could you please check you use the same email?

Do you see the agreement (after pressing the "CLA not signed yet" button) and able to sign it?

PS: You might want to have a look at https://confluence.ecmwf.int/display/SUP/ECMWF+software+on+GitHub
Thanks

[wqu-bom]

Tried the "CLA not signed yet" button, but it did not work (error msg below), nor the link "Details" above.
Description: internal error - server connection terminated

[jameshawkes]

Hi @wqu-bom, our bot was probably blocked by a firewall somewhere causing the error you received above -- although I could not replicate it. The bot is now on listening on port 80 so it should be accessible.

If you wouldn't mind, please try again at this link:
http:https://claassistant.ecmwf.int/ecmwf/eccodes?pullRequest=16

Thanks!

[wqu-bom]

Hi @jameshawkes, I followed the link, but it seems that it has not gone through fully. I got the following (attached).

[wqu-bom]

From: jameshawkes <[email protected]> Sent: Friday, 16 August 2019 11:55 PM To: ecmwf/eccodes <[email protected]> Cc: Weiqing Qu <[email protected]>; Mention <[email protected]> Subject: Re: [ecmwf/eccodes] Improvement on file spliting (#16) Hi @wqu-bom<https://github.com/wqu-bom>, our bot was probably blocked by a firewall somewhere causing the error you received above -- although I could not replicate it. The bot is now on listening on port 80 so it should be accessible. If you wouldn't mind, please try again at this link: http:https://claassistant.ecmwf.int/ecmwf/eccodes?pullRequest=16 Thanks! — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub<#16?email_source=notifications&email_token=ABXJFLXWWKNIHL3G5WSRZNLQE2WSBA5CNFSM4IKFXMAKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOD4OVSSI#issuecomment-522017097>, or mute the thread<https://github.com/notifications/unsubscribe-auth/ABXJFLQGRVXA3FMBSUIZC6DQE2WSBANCNFSM4IKFXMAA>.

[jameshawkes]

Hi @wqu-bom, instead of an attachment I got a copy of the email notification on Github. Can you upload it directly on the Github PR instead or via email?

(You can attach files in the reply box at the bottom)
#16

Otherwise just send me the attachment at

Thanks for your patience.

[jameshawkes]

CLA signed successfully, thank you!

[shahramn]

This has now been merged to BitBucket and will appear in the next release of ecCodes. Many thanks