Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MacOS: fix failing test #12

Merged
merged 1 commit into from
Feb 25, 2019
Merged

MacOS: fix failing test #12

merged 1 commit into from
Feb 25, 2019

Conversation

dtip
Copy link
Contributor

@dtip dtip commented Feb 22, 2019

Thanks to @shahramn for the fix

@dtip dtip requested a review from shahramn February 22, 2019 14:07
Copy link
Collaborator

@shahramn shahramn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The fix I just added to ecCodes (at ECMWF) actually has an extra comment so can you please put this in?

input=${data_dir}/gts/EGRR20150317121020_00493212.DAT
${tools_dir}/bufr_copy -g -w numberOfSubsets=9 $input $tempBufr
# Remove the first line and the last three
${tools_dir}/gts_ls $tempBufr | sed 1d | sed 9,11d > $tempOut

@dtip
Copy link
Contributor Author

dtip commented Feb 22, 2019

The fix I just added to ecCodes (at ECMWF) actually has an extra comment so can you please put this in?

input=${data_dir}/gts/EGRR20150317121020_00493212.DAT
${tools_dir}/bufr_copy -g -w numberOfSubsets=9 $input $tempBufr
# Remove the first line and the last three
${tools_dir}/gts_ls $tempBufr | sed 1d | sed 9,11d > $tempOut

Done!

@dtip dtip requested a review from shahramn February 22, 2019 14:35
@shahramn shahramn merged commit f0cb3d3 into develop Feb 25, 2019
@dtip dtip deleted the dtip-fix-mac-tests branch February 25, 2019 11:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants