Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thank you for your work to support Windows! I am able to build the dtip-windows branch with no issues, other than adding some additional linker dependencies when compiling with statically-linked netCDF (specifically hdf5_hl, szip and zlib). That is probably something to address in ecbuild.
This PR adds memfs support. As there is no API equivalent to fmemopen or funopen for FILE pointers, this is implemented with a temporary file, but the file flags
FILE_ATTRIBUTE_TEMPORARY
andFILE_FLAG_DELETE_ON_CLOSE
hint to the filesystem that it shouldn't be flushed to disk so it still acts like a memory buffer. See this MSDN blog post for a discussion of this technique: It's only temporaryI originally suggested this patch in Jira issue SUP-2586. All of my other suggestions for Windows support have been incorporated (and more!), so this is my only remaining contribution at the moment.
I'm also working on adding support for efficient subsetting of remote files using something similar to GDAL virtual file systems, but that will take some time.