Add a pragma guard around OpenMP directives to fix a bug with GNU10.1/10.2 #22
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
|
Thanks @shlyaeva all good. Just waiting for your CLA signature. |
|
Thank you @wdeconinck! I signed the agreement, maybe it takes some time to show up? |
I think it's possible your user email used to make the commit is not registered in your GitHub profile. When hovering over the "committer" it doesn't allow me to click as it does with other commits. |
climbfuji
approved these changes
Jan 12, 2023
shlyaeva
force-pushed
the
bugfix/gnu_10_2
branch
from
ad85a68
to
6d4a57a
Compare
|
@wdeconinck I corrected the email to the one associated with my profile, and force-pushed that change here, should be all good now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds pragmas to turn off an OpenMP-parallelization of one loop that segfaults with GNU10.1/10.2 (and possibly 10.0), see details and discussion in #20.
Fixes #20