subscribe.simple: Fix MQTTv5 clean_session collision #707
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Even though the top level clean_session parameter is documented as boolean, one would need to pas in None to get the simple() method not error out with v5 protocol
|
Thank for your contribution. For your contribution to be accepted, you will need to sign Eclipse ECA: https://accounts.eclipse.org/user/eca |
|
signed. |
|
Thank. The automated check seem to don't want to re-run, but a manual check confirm that you signed the ECA. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Even though the top level clean_session parameter is documented as boolean,
one would need to pass in None to get the simple() method to not error out with v5 protocol.
(Client raises if with v5 the clean_session parameter is not None)