Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test improvements and database fixes #3006

Merged

Conversation

NorbertHeusser
Copy link
Contributor

Thank you for contributing your time to the Mosquitto project!

Before you go any further, please note that we cannot accept contributions if
you haven't signed the Eclipse Contributor Agreement.
If you aren't able to do that, or just don't want to, please describe your bug
fix/feature change in an issue. For simple bug fixes it is can be just as easy
for us to be told about the problem and then go fix it directly.

Then please check the following list of things we ask for in your pull request:

  • Have you signed the Eclipse Contributor Agreement, using the same email address as you used in your commits?
  • Do each of your commits have a "Signed-off-by" line, with the correct email address? Use "git commit -s" to generate this line for you.
  • If you are contributing a new feature, is your work based off the develop branch?
  • If you are contributing a bugfix, is your work based off the fixes branch?
  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you successfully run make test with your changes locally?

Copy link

codecov bot commented Feb 15, 2024

Codecov Report

Attention: 18 lines in your changes are missing coverage. Please review.

Comparison is base (f6b188a) 81.03% compared to head (56c48bf) 81.27%.

Files Patch % Lines
test/unit/broker/stubs.c 0.00% 9 Missing ⚠️
plugins/persist-sqlite/init.c 89.13% 5 Missing ⚠️
src/database.c 92.30% 3 Missing ⚠️
plugins/persist-sqlite/common.c 91.66% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #3006      +/-   ##
===========================================
+ Coverage    81.03%   81.27%   +0.24%     
===========================================
  Files          186      187       +1     
  Lines        31419    31456      +37     
===========================================
+ Hits         25461    25567     +106     
+ Misses        5958     5889      -69     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

handle_connect.c into database.c

Signed-off-by: Norbert Heusser <[email protected]>
persistent plugin store, if messages removed due to ACL change

Signed-off-by: Norbert Heusser <[email protected]>
@NorbertHeusser NorbertHeusser force-pushed the test-improvements-and-database-fixes branch from 09ef5bd to 56c48bf Compare February 15, 2024 16:21
@ralight ralight merged commit cbf2c68 into eclipse:develop Feb 15, 2024
3 checks passed
@NorbertHeusser NorbertHeusser deleted the test-improvements-and-database-fixes branch February 16, 2024 08:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants