Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

config.mk: fix adns build with glibc >= 2.35 #2986

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

ffontaine
Copy link
Contributor

libanl is not built since glibc 2.35 and bminor/glibc@737e873 resulting in the following build failure:

/home/autobuild/autobuild/instance-15/output-1/host/lib/gcc/or1k-buildroot-linux-gnu/12.3.0/../../../../or1k-buildroot-linux-gnu/bin/ld: cannot find -lanl: No such file or directory

So do not hardcode -lanl in config.mk as anl is already added if needed in src/CMakeLists.txt since
8406c08

Fixes:

libanl is not built since glibc 2.35 and
bminor/glibc@737e873
resulting in the following build failure:

/home/autobuild/autobuild/instance-15/output-1/host/lib/gcc/or1k-buildroot-linux-gnu/12.3.0/../../../../or1k-buildroot-linux-gnu/bin/ld: cannot find -lanl: No such file or directory

So do not hardcode -lanl in config.mk as anl is already added if needed
in src/CMakeLists.txt since
eclipse@8406c08

Fixes:
 - http:https://autobuild.buildroot.org/results/700de2a96e61d922662439ecd465350e4586a1e3

Signed-off-by: Fabrice Fontaine <[email protected]>
@tpetazzoni
Copy link

Thanks @ffontaine for reporting the issue, which we also investigated today. However I think your patch is not completely correct, as it would break the build for toolchains older than glibc 2.35, for which getaddrinfo_a is in the separate libanl.so library.

Also, your sentence "So do not hardcode -lanl in config.mk as anl is already added if needed in src/CMakeLists.txt since 8406c08" is quite confusing. Indeed, there's no relationship between config.mk and CMakeLists.txt.

In addition, the CMakeLists.txt also get it wrong: it only checks for getaddrinfo_a in the anl library. But in fact, now getaddrinfo_a is available directly in the C library itself. So the CMakeLists.txt should check in C library first, then in libanl, and if not disable adns support.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants