Copy scope id when binding to IPv6 Link-Local address #2969
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Thymo van Beers <[email protected]>
Binding to an IPv6 Link-Local address requires the scope ID to be set. If this is not set bind will return EINVAL. Signed-off-by: Thymo van Beers <[email protected]>
|
@ralight May I gently bump this your way? Hoping you can take a look at this bugfix. 🙂 |
ralight
reviewed
Feb 21, 2024
| @@ -673,6 +673,9 @@ static int net__bind_interface(struct mosquitto__listener *listener, struct addr | |||
| memcpy(&((struct sockaddr_in6 *)rp->ai_addr)->sin6_addr, | |||
| &((struct sockaddr_in6 *)ifa->ifa_addr)->sin6_addr, | |||
| sizeof(struct in6_addr)); | |||
|
|
|||
| ((struct sockaddr_in6 *)rp->ai_addr)->sin6_scope_id = ((struct sockaddr_in6 *)ifa->ifa_addr)->sin6_scope_id; | |||
There was a problem hiding this comment.
Can you explain why the memcpy call in line 673 isn't sufficient to copy this value already?
There was a problem hiding this comment.
Is your question why only copying the in6_addr is not enough? That's because for link-local addresses they are only valid for a specific interface, you can specify which interface the address belongs to with the scope id.
If your question is why I didn't group everything into a single memcpy call. That was for readability.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thank you for contributing your time to the Mosquitto project!
Before you go any further, please note that we cannot accept contributions if
you haven't signed the Eclipse Contributor Agreement.
If you aren't able to do that, or just don't want to, please describe your bug
fix/feature change in an issue. For simple bug fixes it is can be just as easy
for us to be told about the problem and then go fix it directly.
Then please check the following list of things we ask for in your pull request:
make testwith your changes locally?Configuring a listener with bind_interface on an interface with an ipv6 link-local address causes Mosquitto to exit with "Error: invalid argument". This happens due to the the IPv6 scope ID not being copied to the returned addrinfo struct when resolving interfaces matching
bind_interface.This PR adds a commit that also copies the sin6_scope_id when a matching interface is found.
Fixes #2696