Fix mosquitto_passwd backup file #2877
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Han Cen <[email protected]>
carldanley
added a commit
to carldanley/home-ops
that referenced
this pull request
Aug 20, 2023
szinn
reviewed
Aug 22, 2023
| @@ -629,13 +629,13 @@ int main(int argc, char *argv[]) | |||
| return 1; | |||
| } | |||
|
|
|||
| backup_file = malloc((size_t)strlen(password_file)+strlen(".backup.XXXXXX")); | |||
| backup_file = malloc((size_t)strlen(password_file)+strlen(".backup.XXXXXX")+1); | |||
There was a problem hiding this comment.
Nit: pull the size out to a separate variable so you don't need to repeat the calculation below.
|
Closing because the owner fixed this in 47ae6dd without any comment here. 😕 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes an issue with the name of the backup file created when using the
mosquitto_passwd -U password.txtcommand. Currently, the command fails with an error that says "Error creating backup password file". Closes #2873.Thank you for contributing your time to the Mosquitto project!
Before you go any further, please note that we cannot accept contributions if
you haven't signed the Eclipse Contributor Agreement.
If you aren't able to do that, or just don't want to, please describe your bug
fix/feature change in an issue. For simple bug fixes it is can be just as easy
for us to be told about the problem and then go fix it directly.
Then please check the following list of things we ask for in your pull request:
make testwith your changes locally?