Link with correct variant of websockets library #2751
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Upstream refers to static library as websockets and shared as websockets_shared Reference: https://github.com/warmcat/libwebsockets/blob/main/lib/CMakeLists.txt#L279
|
Feel free to commit this just fix the bug, I dont need to be credited |
|
Thank you for the suggestion. LWS used to be licensed under LGPL with a static linking exception. In order to satisfy licensing requirements when directly distributing mosquitto including websockets support, the library was static linked. This situation existed only really existed on Windows, and on Windows the resulting static library is renamed as libwebsockets_static, hence why this exists as it does. As LWS decided to relicense to MIT so this problem doesn't exactly exist any more, but anyway I think the option can stay as it is for 2.0.x. |
LocutusOfBorg
pushed a commit
to LocutusOfBorg/mosquitto
that referenced
this pull request
Sep 13, 2023
see: eclipse#2751 Patch contributed by Joachim Zobel <[email protected]> and Daniel Engberg <[email protected]>
LocutusOfBorg
pushed a commit
to LocutusOfBorg/mosquitto
that referenced
this pull request
Sep 26, 2023
see: eclipse#2751 Patch contributed by Joachim Zobel <[email protected]> and Daniel Engberg <[email protected]>
LocutusOfBorg
pushed a commit
to LocutusOfBorg/mosquitto
that referenced
this pull request
Sep 29, 2023
see: eclipse#2751 Patch contributed by Joachim Zobel <[email protected]> and Daniel Engberg <[email protected]>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Upstream refers to static library as websockets and shared as websockets_shared
Reference:
https://github.com/warmcat/libwebsockets/blob/main/lib/CMakeLists.txt#L279