Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mosquitto ctrl allow dynsec client create without password #2743

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from

Conversation

axos88
Copy link
Contributor

@axos88 axos88 commented Feb 2, 2023

Thank you for contributing your time to the Mosquitto project!

Before you go any further, please note that we cannot accept contributions if
you haven't signed the Eclipse Contributor Agreement.
If you aren't able to do that, or just don't want to, please describe your bug
fix/feature change in an issue. For simple bug fixes it is can be just as easy
for us to be told about the problem and then go fix it directly.

Then please check the following list of things we ask for in your pull request:

  • Have you signed the Eclipse Contributor Agreement, using the same email address as you used in your commits?
  • Do each of your commits have a "Signed-off-by" line, with the correct email address? Use "git commit -s" to generate this line for you.
  • If you are contributing a new feature, is your work based off the develop branch?
  • If you are contributing a bugfix, is your work based off the fixes branch?
  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you successfully run make test with your changes locally?

@axos88 axos88 changed the base branch from master to develop February 2, 2023 08:14
…ogin - useful if another plugin is responsible for authenticating this client
@axos88 axos88 force-pushed the mosquitto-ctrl-allow-dynsec-client-create-without-password branch from 8cf3528 to 47262af Compare February 2, 2023 08:15
Copy link
Contributor

@ralight ralight left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this is a good change, thank you. I've made a specific comment on one of the changes. In addition to that, could you please add the new option to the help in dynsec__print_usage()?

If you could also add some entries to test/apps/ctrl/ctrl-dynsec.py in the # Create clients - the valid case, and then the two conflicting cases with the -p option as well that would be great.

Thanks again, this looks useful to me.

request_password = false;
} else if (!strcmp(argv[i], "--no-password")) {
if (password != NULL) {
fprintf(stderr, "Error: -p and --no-password are mutually exclusive.\n");
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You've covered the error case of -p password --no-password, but not --no-password -p password - could you add that check as well please (checking on request_password should do it)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch. Will do in a few days.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants