Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add SSL_OP Flag For TLS Version Selection #2741

Closed
wants to merge 3 commits into from

Conversation

Hyeongon-Kim
Copy link
Contributor

@Hyeongon-Kim Hyeongon-Kim commented Feb 1, 2023

Thank you for contributing your time to the Mosquitto project!

Before you go any further, please note that we cannot accept contributions if
you haven't signed the Eclipse Contributor Agreement.
If you aren't able to do that, or just don't want to, please describe your bug
fix/feature change in an issue. For simple bug fixes it is can be just as easy
for us to be told about the problem and then go fix it directly.

Then please check the following list of things we ask for in your pull request:

  • Have you signed the Eclipse Contributor Agreement, using the same email address as you used in your commits?
  • Do each of your commits have a "Signed-off-by" line, with the correct email address? Use "git commit -s" to generate this line for you.
  • If you are contributing a new feature, is your work based off the develop branch?
  • If you are contributing a bugfix, is your work based off the fixes branch?
  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you successfully run make test with your changes locally?

fix a bug that performs a handshake with tls1.3 even when the tls-version option is set to tlsv1.2 (or tlsv1.1)

@Hyeongon-Kim
Copy link
Contributor Author

Hyeongon-Kim commented Feb 2, 2023

i have checked the old issues,
but i think we should be able to select tls-version clearly for *special situations.
*situations such as implementing and using specific crypto-algorithms based on tls-engine.

Signed-off-by: Hyeongon Kim <[email protected]>
@Hyeongon-Kim
Copy link
Contributor Author

#2722 i added code for this issue

@ralight
Copy link
Contributor

ralight commented Mar 28, 2023

Thank you for this. The issue at #2722 is valid, and I have just added a change for that. What you are proposing here though is not correct in my opinion. The tls version options set a minimum version, whereas your changes set an explicit version.

Is there a reason why setting a minimum version is problematic for engine support?

@ralight ralight closed this Nov 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants