Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

support colon in username in pwfile via double colon #2709

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from

Conversation

stefanschuermans
Copy link

There are smart IoT devices that use the string represeantation of the MAC address as MQTT user name, i.e., a user name containing colon characters. In basic setups of Mosquitto with authentication based on pwfile, user names could not contain colon characters, because the colon is used as a delimiter.

This commit adds supports for colon characters in user names in pwfile, by interpreting the last colon in the pwline as the delimiter and the part in font of it as user name. This works because the hased password never contains a colon.

This approach has been suggested by Rob Swindell as response to PR#2619, which suggested a more complicated approach.

Signed-off-by: Stefan Schuermans [email protected]

Thank you for contributing your time to the Mosquitto project!

Before you go any further, please note that we cannot accept contributions if
you haven't signed the Eclipse Contributor Agreement.
If you aren't able to do that, or just don't want to, please describe your bug
fix/feature change in an issue. For simple bug fixes it is can be just as easy
for us to be told about the problem and then go fix it directly.

Then please check the following list of things we ask for in your pull request:

  • Have you signed the Eclipse Contributor Agreement, using the same email address as you used in your commits?
  • Do each of your commits have a "Signed-off-by" line, with the correct email address? Use "git commit -s" to generate this line for you.
  • If you are contributing a new feature, is your work based off the develop branch?
  • If you are contributing a bugfix, is your work based off the fixes branch?
  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you successfully run make test with your changes locally?

There are smart IoT devices that use the string represeantation of the MAC
address as MQTT user name, i.e., a user name containing colon characters.
In basic setups of Mosquitto with authentication based on pwfile, user names
could not contain colon characters, because the colon is used as a delimiter.

This commit adds supports for colon characters in user names in pwfile, by
interpreting the last colon in the pwline as the delimiter and the part in
font of it as user name. This works because the hased password never contains
a colon.

This approach has been suggested by Rob Swindell as response to PR#2619, which
suggested a more complicated approach.

Signed-off-by: Stefan Schuermans <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant