support colon in username in pwfile via double colon #2709
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There are smart IoT devices that use the string represeantation of the MAC address as MQTT user name, i.e., a user name containing colon characters. In basic setups of Mosquitto with authentication based on pwfile, user names could not contain colon characters, because the colon is used as a delimiter.
This commit adds supports for colon characters in user names in pwfile, by interpreting the last colon in the pwline as the delimiter and the part in font of it as user name. This works because the hased password never contains a colon.
This approach has been suggested by Rob Swindell as response to PR#2619, which suggested a more complicated approach.
Signed-off-by: Stefan Schuermans [email protected]
Thank you for contributing your time to the Mosquitto project!
Before you go any further, please note that we cannot accept contributions if
you haven't signed the Eclipse Contributor Agreement.
If you aren't able to do that, or just don't want to, please describe your bug
fix/feature change in an issue. For simple bug fixes it is can be just as easy
for us to be told about the problem and then go fix it directly.
Then please check the following list of things we ask for in your pull request:
If you are contributing a bugfix, is your work based off the fixes branch?make test
with your changes locally?