Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix SSL_connect misuse #2595

Closed
wants to merge 13 commits into from
Prev Previous commit
Fix SSL_connect misuse
SSL_ERROR_SYSCALL is fatal error, should stop connection
  • Loading branch information
CastleOnTheHill committed Jul 19, 2022
commit ebe8624dd3d034e143b5ce876140c9b057a5c599
4 changes: 0 additions & 4 deletions lib/net_mosq.c
Original file line number Diff line number Diff line change
Expand Up @@ -573,10 +573,6 @@ int net__socket_connect_tls(struct mosquitto *mosq)
ret = SSL_connect(mosq->ssl);
if(ret != 1) {
err = SSL_get_error(mosq->ssl, ret);
if (err == SSL_ERROR_SYSCALL) {
mosq->want_connect = true;
return MOSQ_ERR_SUCCESS;
}
if(err == SSL_ERROR_WANT_READ){
mosq->want_connect = true;
/* We always try to read anyway */
Expand Down