Fixing a memory leak when another broker connects. Closes #2057 #2064
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Przemek Zygmunt <[email protected]>
przemyslawzygmunt
force-pushed
the
fixes
branch
from
ccd6466
to
e29bb1c
Compare
|
I'm afraid it isn't correct, it results in a use-after-free in some situations. Thanks very much for spending time looking at it though. Leave it with me and I'll have a fix in place soon. |
|
I was expecting that this is not the right place. As I mentioned, I spent several dozen minutes reviewing the code, which is not enough to properly define where to call context__cleanup. |
|
Yes, it took me most of last evening to verify that it wasn't correct :) |
|
However, I hope you managed to reproduce the leak described in #2057. |
|
Yes I did, thank you for your help there. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Due to unfamiliarity with your code, I am not sure if using context__cleanup in the place I suggested is correct, but in my tests it solves the problem.