Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed some VS2017 compilation error and warnings #1916

Merged
merged 8 commits into from
Dec 2, 2020

Conversation

raspopov
Copy link
Contributor

/W1 VS2017

mosquitto\lib\net_mosq.c(433): error C4703: potentially uninitialized local pointer variable 'ainfo_bind' used
mosquitto\lib\net_mosq.c(922): warning C4133: 'function': incompatible types - from 'int *' to 'const char *'

/W4 VS2017 (without TLS)

mosquitto\lib\send_connect.c(140): warning C4267: 'function': conversion from 'size_t' to 'uint16_t', possible loss of data
mosquitto\lib\send_connect.c(142): warning C4267: 'function': conversion from 'size_t' to 'uint16_t', possible loss of data

mosquitto\lib\mosquitto.c(59): warning C4244: 'function': conversion from 'ULONGLONG' to 'unsigned int', possible loss of data
mosquitto\lib\mosquitto.c(591): warning C4018: '<': signed/unsigned mismatch

mosquitto\lib\loop.c(108): warning C4018: '>': signed/unsigned mismatch
mosquitto\lib\loop.c(324): warning C4701: potentially uninitialized local variable 'rc' used
mosquitto\lib\loop.c(401): warning C4701: potentially uninitialized local variable 'rc' used
mosquitto\lib\loop.c(417): warning C4701: potentially uninitialized local variable 'rc' used

mosquitto\lib\misc_mosq.c(71): warning C4057: 'function': 'LPDWORD' differs in indirection to slightly different base types from 'int *'

Then please check the following list of things we ask for in your pull request:

  • Have you signed the Eclipse Contributor Agreement, using the same email address as you used in your commits?
  • Do each of your commits have a "Signed-off-by" line, with the correct email address? Use "git commit -s" to generate this line for you.
  • If you are contributing a new feature, is your work based off the develop branch?
  • If you are contributing a bugfix, is your work based off the fixes branch?
  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you successfully run make test with your changes locally?

@ralight ralight merged commit 71845d2 into eclipse:develop Dec 2, 2020
@ralight
Copy link
Contributor

ralight commented Dec 2, 2020

Thank you, they all look fine.

fAuernigg pushed a commit to fAuernigg/mosquitto that referenced this pull request Jan 4, 2021
* Fixed some VS2017 compilation errors and warnings.

Signed-off-by: raspopov <[email protected]>
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 11, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants