Fix send pkt #1487
Merged
Fix send pkt #1487
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
According to the documentation of python 3 socket::send method (https://docs.python.org/3/library/socket.html#socket.socket.send), the call to send must be retry until all data is sent while sending packet with a "large" amount of data. Signed-off-by: Jerome Malinge <[email protected]>
To keep the broker session working while launching several tests on the same broker, the last packet of this transaction must be sent. Signed-off-by: Jerome Malinge <[email protected]>
Signed-off-by: Jerome Malinge <[email protected]>
Signed-off-by: Jerome Malinge <[email protected]>
|
Lovely, thanks for choosing Mosquitto as your first pull request :) This all looks good - small changes with straightforward descriptions, and improving tests - even better. Thanks for your contribution! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
make testwith your changes locally?Hi,
This fixes some issues I spotted while working on acceptance tests.
This is my first pull request on Github, I think I made everything properly but do not hesitate to tell me if this is not the case.