Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #include guard in config.h #1304

Merged
merged 1 commit into from
Jun 13, 2019

Conversation

dandrader
Copy link

Signed-off-by: Daniel d'Andrada [email protected]

  • If you are contributing a new feature, is your work based off the develop branch?
  • If you are contributing a bugfix, is your work based off the fixes branch?
  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you successfully run make test with your changes locally?
  • Have you signed the Eclipse Contributor Agreement, using the same email address as you used in your commits?
  • Do each of your commits have a "Signed-off-by" line, with the correct email address? Use "git commit -s" to generate this line for you.

Signed-off-by: Daniel d'Andrada <[email protected]>
@karlp
Copy link
Contributor

karlp commented Jun 4, 2019

I'm curious what you were doing that triggered a problem here? Or was this just code inspection?

@dandrader
Copy link
Author

dandrader commented Jun 5, 2019

@karlp

I got this error when building it with NDK r12b:

target thumb C: mosquitto <= esrlabs/Native/Mosquitto/src/mosquitto.c
In file included from esrlabs/Native/Mosquitto/src/mosquitto_broker_internal.h:21:0,
                 from esrlabs/Native/Mosquitto/src/mosquitto.c:52:
esrlabs/Native/Mosquitto/config.h:15:0: warning: "_POSIX_C_SOURCE" redefined
 #  define _POSIX_C_SOURCE 200809L
 ^
In file included from bionic/libc/include/unistd.h:33:0,
                 from esrlabs/Native/Mosquitto/src/mosquitto.c:21:
bionic/libc/include/sys/cdefs.h:430:0: note: this is the location of the previous definition
 #define _POSIX_C_SOURCE  200809
 ^

@ralight ralight merged commit 5d64678 into eclipse:fixes Jun 13, 2019
@ralight
Copy link
Contributor

ralight commented Jun 13, 2019

Thank you, this will be part of 1.6.3 shortly.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 11, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants