Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed Segmentation Fault / NULLptr dereference #1268

Merged
merged 1 commit into from
May 10, 2019

Conversation

tillz
Copy link
Contributor

@tillz tillz commented May 9, 2019

Signed-off-by: Till Zimmermann [email protected]

This fixes a Segmentation Fault in the client tools I encountered recently when supplying a malformed URL to the -L-Flag (missing trailing /) (cf. #1248).

  • If you are contributing a new feature, is your work based off the develop branch?
  • If you are contributing a bugfix, is your work based off the fixes branch?
  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you successfully run make test with your changes locally?
  • Have you signed the Eclipse Contributor Agreement, using the same email address as you used in your commits?
  • Do each of your commits have a "Signed-off-by" line, with the correct email address? Use "git commit -s" to generate this line for you.

@karlp
Copy link
Contributor

karlp commented May 9, 2019

This was fixed in 203949a and the linked ticket already.

@ralight
Copy link
Contributor

ralight commented May 10, 2019

@karlp This is another one.

@tillz Thanks very much, a fairly minor problem but I'm very pleased to fix it.

@ralight ralight merged commit c411b73 into eclipse:fixes May 10, 2019
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 11, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants