Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ssl fixes for ENGINE and UI includes #1255

Merged
merged 2 commits into from
May 29, 2019
Merged

Conversation

karlp
Copy link
Contributor

@karlp karlp commented May 2, 2019

Not sure if the ui.h include is part of engine support or not, but it needs to be included for the openwrt buildroot at least.

The ENGINE=no support is just something quick to get me to compile again. I may have not taken the preferred paths of warning that things might not be available.

I'm completely ok with simply requiring ENGINE support. OpenWrt is defaulting to engine ON now, I've only extended the patching as support for building without engine support was already in the codebase.

  • [n/a ] If you are contributing a new feature, is your work based off the develop branch?
  • [no (fixes branch isn't uptodate) ] If you are contributing a bugfix, is your work based off the fixes branch?
  • [x ] Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you successfully run make test with your changes locally?
  • [x ] Have you signed the Eclipse Contributor Agreement, using the same email address as you used in your commits?
  • [x ] Do each of your commits have a "Signed-off-by" line, with the correct email address? Use "git commit -s" to generate this line for you.

karlp added 2 commits May 2, 2019 16:44
Alternatively, just drop support for this config.

Signed-off-by: Karl Palsson <[email protected]>
@ralight ralight added this to the 1.6.3 milestone May 22, 2019
@ralight
Copy link
Contributor

ralight commented May 22, 2019

This is coming up as you not having signed the ECA, maybe it expired?

@karlp
Copy link
Contributor Author

karlp commented May 22, 2019

expired? wtf. I'll try and make them happy again.

@karlp
Copy link
Contributor Author

karlp commented May 23, 2019

Yep, was expired. have re-signed. Don't understand the travis failures though

@ralight ralight changed the base branch from master to fixes May 29, 2019 09:23
@ralight ralight merged commit 44d1700 into eclipse:fixes May 29, 2019
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 11, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants