Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

mosquitto_auth_plugin_cleanup never called by mosquitto? #900

Closed
JulianZhao opened this issue Jul 31, 2018 · 2 comments
Closed

mosquitto_auth_plugin_cleanup never called by mosquitto? #900

JulianZhao opened this issue Jul 31, 2018 · 2 comments
Labels
Component: mosquitto-broker Status: Completed Nothing further to be done with this issue, it can be closed by the requestor or committer. Type: Bug
Milestone
1.5.1

Comments

@JulianZhao
Copy link

mosquitto_plugin.h says:

Function: mosquitto_auth_plugin_cleanup
Called when the broker is shutting down. This will only ever be called once per plugin.
Note that <mosquitto_auth_security_cleanup> will be called directly before this function.

but I didn't find any code in mosquitto for this. plugin->plugin_cleanup_v3 is assigned but never called.

mosquitto_auth_security_cleanup is called normally.
@toast-uz
Copy link
Contributor

Did you have any actual failure in addition to the code review? Did your issue reproduce on plugin v3 only, or on any version?

@toast-uz toast-uz added the Status: Blocked Another issue needs to be resolved first label Jul 31, 2018
ralight added a commit that referenced this issue Aug 1, 2018
@ralight
[Broker] Fix auth plugin cleanup function not being called.
8bbb588 
Closes #900.

Thanks to Julian Zhao.

Signed-off-by: Roger A. Light <[email protected]>
@ralight
Copy link
Contributor

ralight commented Aug 1, 2018

Thanks for reporting this, it should be fixed in the fixes branch now. If you could confirm and close the issue if it works for you.

@ralight ralight added Type: Bug Component: mosquitto-broker Status: Completed Nothing further to be done with this issue, it can be closed by the requestor or committer. and removed Status: Blocked Another issue needs to be resolved first labels Aug 1, 2018
@ralight ralight added this to the 1.5.1 milestone Aug 1, 2018
@ralight ralight closed this as completed Aug 14, 2018
ralight added a commit that referenced this issue Nov 8, 2018
@ralight
[Broker] Fix auth plugin cleanup function not being called.
9f8e2a1 
Closes #900.

Thanks to Julian Zhao.

Signed-off-by: Roger A. Light <[email protected]>
@lock lock bot locked as resolved and limited conversation to collaborators Aug 7, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
Component: mosquitto-broker Status: Completed Nothing further to be done with this issue, it can be closed by the requestor or committer. Type: Bug
Projects
None yet
Milestone
1.5.1
Development

No branches or pull requests
3 participants
@ralight @JulianZhao @toast-uz