Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

develop branch does not compile on Windows #656

Closed
archerian opened this issue Dec 22, 2017 · 3 comments
Closed

develop branch does not compile on Windows #656

archerian opened this issue Dec 22, 2017 · 3 comments
Labels
Component: build Related to the Makefiles / build scripts in the project. Type: Bug
Milestone

Comments

@archerian
Copy link

Several issues prevent a successful build on Windows.. some of which are

strncasecmp not available (use_strnicmp)
closedir not available (use FindClose)
undeclared local variables in config__get_dir_files (len, i, dh/fh)
SigThreadProc function might be missing a closing brace, and undeclared before use at CreateThread

@ralight
Copy link
Contributor

ralight commented Jan 6, 2018

Thanks we'll take a look. For completeness, what are you using to build with?

@archerian
Copy link
Author

VS 2017 (15.15.1)

ralight added a commit that referenced this issue Jan 6, 2018
Thanks to Arun Kirthi Cherian.

Bug: #656
@ralight ralight added Type: Bug Component: build Related to the Makefiles / build scripts in the project. labels Jan 6, 2018
@ralight ralight added this to the 1.5 milestone Jan 6, 2018
@ralight
Copy link
Contributor

ralight commented Jan 6, 2018

This commit fixes the build with VS 2015. It disables static libraries by default for the moment.

Thanks for reporting it.

@ralight ralight closed this as completed Jan 6, 2018
@lock lock bot locked as resolved and limited conversation to collaborators Aug 8, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Component: build Related to the Makefiles / build scripts in the project. Type: Bug
Projects
None yet
Development

No branches or pull requests

2 participants