Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

API docs describe keepalive incorrectly #621

Open
ElmerLastdrager opened this issue Nov 13, 2017 · 2 comments
Open

API docs describe keepalive incorrectly #621

ElmerLastdrager opened this issue Nov 13, 2017 · 2 comments

Comments

@ElmerLastdrager
Copy link

In the API docs, the description of the keepalive value is wrong. It currently states:

keepalive the number of seconds after which the broker should send a PING message to the client if no other messages have been exchanged in that time.

This should read:

keepalive the number of seconds after which the client should send a PING message to the broker if no other messages have been exchanged in that time.

Relevant lines:

* keepalive - the number of seconds after which the broker should send a PING

* keepalive - the number of seconds after which the broker should send a PING

* keepalive - the number of seconds after which the broker should send a PING

* keepalive - the number of seconds after which the broker should send a PING

* keepalive - the number of seconds after which the broker should send a PING

szarta added a commit to szarta/mosquitto that referenced this issue Nov 13, 2017
@szarta
Copy link

szarta commented Nov 13, 2017

Agreed - keepalive is needed by client - if no messages prior to the keepalive time, ping should be sent by the client.

@PierreF
Copy link
Contributor

PierreF commented Jan 4, 2018

@szarta could you please submit your fix as PR ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants