Fix for issue #537: should not log connection message if option disabled #613
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…n to log it disabled Signed-off-by: Brandon Arrendondo <[email protected]>
|
I will test and find the other ones as well and include those in the pull request. |
Signed-off-by: Brandon Arrendondo <[email protected]>
|
The help for connection_messages logging states that it should affect all messages relating to clients connecting and disconnecting, so I found those and made sure they were wrapped appropriately. |
Signed-off-by: Brandon Arrendondo <[email protected]>
|
I'm not convinced that all messages are connection related messages. The ACL denied message don't look connection related for me. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added configuration check before printing connection message.
Signed-off-by: Brandon Arrendondo [email protected]