Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Complete quoting for parameters of some CMake commands #4

Closed
elfring opened this issue Mar 13, 2016 · 1 comment
Closed

Complete quoting for parameters of some CMake commands #4

elfring opened this issue Mar 13, 2016 · 1 comment
Milestone
1.4.9

Comments

@elfring
Copy link

elfring commented Mar 13, 2016

Some parameters (like "${SYSCONFDIR}" and "${mosquitto_SOURCE_DIR}") are passed to CMake commands in your build scripts without enclosing them by quotation marks. I see that these places will result in build difficulties if the contents of the used variables will contain special characters like semicolons.

I would recommend to apply advices from a wiki article.
ralight added a commit that referenced this issue Mar 13, 2016
@ralight
Fix string quoting in CMakeLists.txt. Closes #4.
69a08ab
@ralight ralight added this to the 1.4.9 milestone Mar 13, 2016
@ralight
Copy link
Contributor

ralight commented Mar 15, 2016

Closed in the fixes branch.

@ralight ralight closed this as completed Mar 15, 2016
@gmatt76 gmatt76 mentioned this issue Mar 17, 2017
Closed
@drJeckyll drJeckyll mentioned this issue Nov 21, 2018
Closed
@lock lock bot locked as resolved and limited conversation to collaborators Aug 8, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
1.4.9
Development

No branches or pull requests
2 participants
@ralight @elfring