Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mosquitto_reinitialise documentation error #2489

Closed
rroguski opened this issue Mar 22, 2022 · 1 comment
Closed

mosquitto_reinitialise documentation error #2489

rroguski opened this issue Mar 22, 2022 · 1 comment
Labels
Component: libmosquitto Status: Completed Nothing further to be done with this issue, it can be closed by the requestor or committer. Type: Bug

Comments

@rroguski
Copy link

Hi,

had a nasty bug in my code and by accident found a documentation error in
https://github.com/eclipse/mosquitto/blob/master/include/mosquitto.h#L327

In the function's implementation https://github.com/eclipse/mosquitto/blob/master/lib/mosquitto.c#L140 one can see that instead of returning MOSQ_ERR_NOMEM it returns MOSQ_ERR_MALFORMED_UTF8 here: https://github.com/eclipse/mosquitto/blob/master/lib/mosquitto.c#L167

@ralight
Copy link
Contributor

ralight commented Aug 10, 2022

Thank you! It actually should be returning MOSQ_ERR_NOMEM as well as MOSQ_ERR_MALFORMED_UTF8. I've fixed both parts.

ralight added a commit that referenced this issue Aug 10, 2022
@ralight ralight added Type: Bug Component: libmosquitto Status: Completed Nothing further to be done with this issue, it can be closed by the requestor or committer. labels Aug 10, 2022
@ralight ralight closed this as completed Aug 16, 2022
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 20, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Component: libmosquitto Status: Completed Nothing further to be done with this issue, it can be closed by the requestor or committer. Type: Bug
Projects
None yet
Development

No branches or pull requests

2 participants