New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
#if defined(LIBRESSL_VERSION_NUMBER) #2198
Labels
Component: mosquitto-clients
Status: Completed
Nothing further to be done with this issue, it can be closed by the requestor or committer.
Type: Bug
Milestone
Comments
Thanks for the hints! |
ralight
added
Component: mosquitto-clients
Status: Accepted
It's clear what the subject of the issue is about, and what the resolution should be.
Type: Bug
labels
Aug 22, 2021
ralight
added
Status: Completed
Nothing further to be done with this issue, it can be closed by the requestor or committer.
and removed
Status: Accepted
It's clear what the subject of the issue is about, and what the resolution should be.
labels
Aug 24, 2021
This will be in 2.0.12 shortly. |
rozhuk-im
added a commit
to rozhuk-im/freebsd-ports
that referenced
this issue
Nov 9, 2021
rozhuk-im
added a commit
to rozhuk-im/freebsd-ports
that referenced
this issue
Nov 9, 2021
rozhuk-im
added a commit
to rozhuk-im/freebsd-ports
that referenced
this issue
Nov 10, 2021
rozhuk-im
added a commit
to rozhuk-im/freebsd-ports
that referenced
this issue
Nov 10, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
Component: mosquitto-clients
Status: Completed
Nothing further to be done with this issue, it can be closed by the requestor or committer.
Type: Bug
lib/options.c
currently has two#if defined(LIBRESSL_VERSION_NUMBER)
code paths.mosquitto/lib/options.c
Lines 397 to 400 in d5ecd9f
and
mosquitto/lib/options.c
Lines 505 to 506 in d5ecd9f
This is to avoid using
SSL_CTX_up_ref()
that presumably was not available at the time of writing the code.This function has been available since LibreSSL 2.7.0 and is thus available in all supported versions (currently 3.2.x and 3.3.x).
It would be nice if these
&& !defined(LIBRESSL_VERSION_NUMBER)
could be removed, as in LibreSSL 3.4.x theSSL_CTX
will become opaque, so the build will break.Concerning the remaining two
!defined(LIBRESSL_VERSION_NUMBER)
paths in the source, theSSL_CTX_set_ciphersuites()
function will become available in LibreSSL 3.4.x, so it would be nice if those could be weakened to&& (!defined(LIBRESSL_VERSION_NUMBER) || LIBRESSL_VERSION_NUMBER > 0x3040000fL)
.The text was updated successfully, but these errors were encountered: