Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CMake build for plugins/message-timestamp cannot find opensslconf.h with cross-compiler #2160

Closed
Ozaq opened this issue Mar 30, 2021 · 1 comment

Comments

@Ozaq
Copy link

Ozaq commented Mar 30, 2021

In a cross-build environment I noticed that that the CMake build for plugins/message-timestamp with TLS enabled is currently broken because opensslconf.h cannot be found. Note the header is only missing for this specific target.

I had a cursory look at the CMake file and it seems that plugins/message-timestamp/CMakeLists.txt is not adding ${OPENSSL_INCLUDE_DIRECTORIES} to to the include directories. opensslconf.h is transitively included by config.h

This does not seem to be an issue in a non-cross build because because /usr/include and /usr/local/include are part of the default include paths. This is not the case when using a cross compiler.

Additionally this seems to be a regression between 1.6.x and 2.0.x as I discovered this during an upgrade from 1.6 to 2.0 in the same build environment.

Edit:spelling

@Ozaq Ozaq changed the title CMake build for plugins/message-timestamp cannot find opensslconf.h CMake build for plugins/message-timestamp cannot find opensslconf.h with cross-compiler Mar 30, 2021
ralight added a commit that referenced this issue Apr 1, 2021
@ralight
Copy link
Contributor

ralight commented Apr 1, 2021

Thank you, that should now be fixed in the fixes branch.

@ralight ralight closed this as completed Apr 1, 2021
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 11, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants