Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Build on Solaris x86 #2136

Closed
chuckunix opened this issue Mar 17, 2021 · 3 comments
Closed

Build on Solaris x86 #2136

chuckunix opened this issue Mar 17, 2021 · 3 comments
Milestone
2.0.10

Comments

@chuckunix
Copy link

chuckunix commented Mar 17, 2021 •
edited

config.mk check SunOS version and implies SPARC-only compiler options by default(.
The proposed change tested on x64 for 11.4 SRU29/gcc9

[oz]# diff config.mk config.mk.org 
145d144
<       ARCH:=$(shell uname -p)
203,204d201
<       SEDINPLACE:=    
<       ifeq ($(ARCH),sparc)
210,213c207
<       endif
<       ifeq ($(ARCH),i386)
<               LIB_CFLAGS:=$(LIB_CFLAGS) -fPIC 
<       endif
---

Rgds,
Dmitry.
@ralight
Copy link
Contributor

ralight commented Mar 21, 2021

Thank you, I don't have access to Solaris so it's difficult to test. Your patch doesn't apply however, could you perhaps use diff -u instead?

@chuckunix
Copy link
Author

Good day,

config.mk.diff.txt

ralight added a commit that referenced this issue Apr 3, 2021
@ralight
Fix segfault on client sending malformed CONNACk.
fdc8afd 
CVE-xxxx-xxxx: If an authenticated client connected with MQTT v5 sent a
malformed CONNACK message to the broker a NULL pointer dereference occurred,
most likely resulting in a segfault. This will be updated with the CVE
number when it is assigned.
Affects versions 2.0.0 to 2.0.9 inclusive.

Closes #2136. Thanks to Bryan Pearson.
ralight added a commit that referenced this issue Apr 3, 2021
@ralight
Fix build on Solaris non-sparc.
eead0d2 
Closes #2136. Thanks to chuckunix.
@ralight
Copy link
Contributor

ralight commented Apr 3, 2021

Thanks, that will be part of 2.0.10 shortly.

@ralight ralight closed this as completed Apr 3, 2021
@ralight ralight added this to the 2.0.10 milestone Apr 3, 2021
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 11, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
2.0.10
Development

No branches or pull requests
2 participants
@ralight @chuckunix