SIGHUP disconnects bridge connection

[ghost]

It was noticed that bridge connections will always be dropped when running "killall -SIGHUP mosquitto". Studying my config, it seems like this only happens when I am NOT setting allow_anonymous to true. (default it is false)

Problem is following block

mosquitto/src/security_default.c

Line 1127 in cc47eab

if(!allow_anonymous && !context->username){

		if(!allow_anonymous && !context->username){
			mosquitto__set_state(context, mosq_cs_disconnecting);
			do_disconnect(db, context, MOSQ_ERR_AUTH);
			continue;
		}

Of course, a bridge doesn't have a username and as I said, allow_anonymous is false. So mosquitto_security_apply_default will just kick my bridge all the time

If I am just setting a remote_username (to some random value) then following section of code will kick my bridge connection

mosquitto/src/security_default.c

Line 1239 in cc47eab

/* Username/password check only if the identity/subject check not used */

		/* Username/password check only if the identity/subject check not used */
			if(mosquitto_unpwd_check(db, context, context->username, context->password) != MOSQ_ERR_SUCCESS){
				mosquitto__set_state(context, mosq_cs_disconnecting);
				do_disconnect(db, context, MOSQ_ERR_AUTH);
				continue;
			}

I think both miss a !context->is_bridge && at the beginning

[ralight]

Thanks for the report, I agree with your general suggestion and it should now be fixed and will be part of 2.0.3 shortly.