Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mosquitto_rr doesn't actually support v3.1.1 #1881

Closed
Arnavion opened this issue Nov 7, 2020 · 2 comments
Closed

mosquitto_rr doesn't actually support v3.1.1 #1881

Arnavion opened this issue Nov 7, 2020 · 2 comments

Comments

@Arnavion
Copy link

Arnavion commented Nov 7, 2020

A command like:

mosquitto_rr ... --topic ... --message ... -e ... --protocol-version mqttv311

will use the value of -e (cfg.response_topic) both for subscribing to (okay) and as properties of the PUBLISH message (not okay). This means mosquitto_publish_v5 fails with MOSQ_ERR_NOT_SUPPORTED.

On a related note, the response topic is parsed as a publish topic rather than a subscription topic, which is correct for v5. But for v3.1.1 it's more convenient to parse it as a subscription topic to allow wildcards.


Incidentally the man page doesn't document the -e parameter. It's mentioned in the synopsis section but not in the options section. Even the synopsis section incorrectly marks it as an optional parameter and groups it within the {} group that contains the -h and -L alternatives.

@Arnavion Arnavion changed the title moquitto_rr doesn't actually support v3.1.1 mosquitto_rr doesn't actually support v3.1.1 Nov 7, 2020
ralight added a commit that referenced this issue Nov 7, 2020
@ralight
Copy link
Contributor

ralight commented Nov 7, 2020

Thank you, that's a good description. It's now fixed, although I disagree with you about the response topic. It would be harder to use in v3.1.1 certainly, but changing to allow wildcards in the response topic doesn't feel right.

@Arnavion
Copy link
Author

Arnavion commented Nov 8, 2020

Thanks for the fix.

@Arnavion Arnavion closed this as completed Nov 8, 2020
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 11, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants