Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

makefile tries to install from docs directory even when with_docs is turned off #184

Closed
minghuadev opened this issue Jun 5, 2016 · 2 comments
Labels
Component: build Related to the Makefiles / build scripts in the project. Type: Bug
Milestone

Comments

@minghuadev
Copy link

Hi, This is just a bit annoying, not really a big issue. I've been working around by just comment out this line 40 from makefile:

     38 install : mosquitto
     39         set -e; for d in ${DIRS}; do $(MAKE) -C $${d} install; done
     40         ##set -e; for d in ${DOCDIRS}; do $(MAKE) -C $${d} install; done
     41         $(INSTALL) -d ${DESTDIR}/etc/mosquitto

Or by surrounding the line with conditions:

 install : mosquitto
        set -e; for d in ${DIRS}; do $(MAKE) -C $${d} install; done
+ifeq ($(WITH_DOCS),yes)
        set -e; for d in ${DOCDIRS}; do $(MAKE) -C $${d} install; done
+endif
        $(INSTALL) -d ${DESTDIR}/etc/mosquitto

The reason I avoid building the docs is for fast turn-around time. I also turn off many other options. And avoid the lib and client directories since I only work on the websocket server part.

If this can be fixed from the source it may benefit other people too.

Thanks.

ralight added a commit that referenced this issue Jun 6, 2016
@ralight ralight added the Component: build Related to the Makefiles / build scripts in the project. label Jun 6, 2016
@ralight ralight added this to the Fixes-next milestone Jun 6, 2016
@ralight
Copy link
Contributor

ralight commented Jun 6, 2016

Thanks, that's fixed now.

@ralight ralight closed this as completed Jun 6, 2016
@minghuadev
Copy link
Author

Thank you very much for the quick response!

@lock lock bot locked as resolved and limited conversation to collaborators Aug 8, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Component: build Related to the Makefiles / build scripts in the project. Type: Bug
Projects
None yet
Development

No branches or pull requests

2 participants